You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/04/22 16:23:21 UTC
[GitHub] [lucene-solr] cpoerschke opened a new pull request #2482: SOLR-15356: Deprecate UninvertDocValuesMergePolicyFactory
cpoerschke opened a new pull request #2482:
URL: https://github.com/apache/lucene-solr/pull/2482
I think a `solr/CHANGES.txt` entry for Solr 8.x is not warranted given the specialised use of the class but it would seem nice to provide some indication to anyone using it w.r.t. the class being removed in future Solr 9 via the https://github.com/apache/solr/pull/83 change?
https://issues.apache.org/jira/browse/SOLR-15356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #2482: SOLR-15356: Deprecate UninvertDocValuesMergePolicyFactory
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #2482:
URL: https://github.com/apache/lucene-solr/pull/2482#discussion_r619351945
##########
File path: solr/core/src/java/org/apache/solr/update/SolrIndexConfig.java
##########
@@ -43,6 +43,7 @@
import org.apache.solr.index.MergePolicyFactory;
import org.apache.solr.index.MergePolicyFactoryArgs;
import org.apache.solr.index.SortingMergePolicy;
+import org.apache.solr.index.UninvertDocValuesMergePolicyFactory;
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #2482: SOLR-15356: Deprecate UninvertDocValuesMergePolicyFactory
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #2482:
URL: https://github.com/apache/lucene-solr/pull/2482#discussion_r619351440
##########
File path: solr/core/src/java/org/apache/solr/update/SolrIndexConfig.java
##########
@@ -303,6 +304,10 @@ private MergePolicy buildMergePolicy(SolrResourceLoader resourceLoader, IndexSch
new Class[] { SolrResourceLoader.class, MergePolicyFactoryArgs.class, IndexSchema.class },
new Object[] {resourceLoader, mpfArgs, schema });
+ if (mpf instanceof UninvertDocValuesMergePolicyFactory) {
+ log.warn("UninvertDocValuesMergePolicyFactory will be removed in Solr 9 due to changes in Lucene 9.");
+ }
+
Review comment:
```suggestion
```
##########
File path: solr/core/src/java/org/apache/solr/update/SolrIndexConfig.java
##########
@@ -303,6 +304,10 @@ private MergePolicy buildMergePolicy(SolrResourceLoader resourceLoader, IndexSch
new Class[] { SolrResourceLoader.class, MergePolicyFactoryArgs.class, IndexSchema.class },
new Object[] {resourceLoader, mpfArgs, schema });
+ if (mpf instanceof UninvertDocValuesMergePolicyFactory) {
Review comment:
Ah, good point! I'd started with the warning here and added the deprecation as an afterthought but yes it's much cleaner to have only the regular deprecation logging, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] cpoerschke merged pull request #2482: SOLR-15356: Deprecate UninvertDocValuesMergePolicyFactory
Posted by GitBox <gi...@apache.org>.
cpoerschke merged pull request #2482:
URL: https://github.com/apache/lucene-solr/pull/2482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2482: SOLR-15356: Deprecate UninvertDocValuesMergePolicyFactory
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #2482:
URL: https://github.com/apache/lucene-solr/pull/2482#discussion_r618630451
##########
File path: solr/core/src/java/org/apache/solr/update/SolrIndexConfig.java
##########
@@ -303,6 +304,10 @@ private MergePolicy buildMergePolicy(SolrResourceLoader resourceLoader, IndexSch
new Class[] { SolrResourceLoader.class, MergePolicyFactoryArgs.class, IndexSchema.class },
new Object[] {resourceLoader, mpfArgs, schema });
+ if (mpf instanceof UninvertDocValuesMergePolicyFactory) {
Review comment:
When Solr loads a deprecated class (see SolrResourceLoader line 537), it detects this and logs a warning. I think that's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org