You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/09/15 13:05:52 UTC

[GitHub] [druid] AmatyaAvadhanula commented on pull request #13076: Independent Supervisor Creation/Updation/Termination

AmatyaAvadhanula commented on PR #13076:
URL: https://github.com/apache/druid/pull/13076#issuecomment-1248075809

   @kfaraz thank you for the review!
     
    
   > Could you share some more details regarding why these changes are needed? 
   
   A supervisor may take a long time to terminate gracefully or time out trying to do so (80s is the default).
   It would be helpful to let other supervisors be created / suspended / modified / terminated without having to be blocked on operations of others', despite these not being frequent operations, as it may affect the task creation and hence the ingestion itself.
    <br/>
    
   > Maps such as autoscalers etc are already ConcurrentHashMaps and don't really need separate locks.
    
   Thank you, I've applied this suggestion and removed the locks.
    <br/>
    
   > For example, what would happen when the SupervisorManager is stopping and a new supervisor is submitted?
   
   This has now been handled within stop() of the SupervisorManager by synchronizing a supervisor's cleanup on the same lock used to synchronize its creation or termination.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org