Re: [PR] [SPARK-46090][SQL] Support plan fragment level SQL configs in AQE [spark]

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #44013:
URL: https://github.com/apache/spark/pull/44013#discussion_r1411749119


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SQLConfHelper.scala:
##########
@@ -29,4 +30,32 @@ trait SQLConfHelper {
    * See [[SQLConf.get]] for more information.
    */
   def conf: SQLConf = SQLConf.get
+
+  /**
+   * Sets all SQL configurations specified in `pairs`, calls `f`, and then restores all SQL
+   * configurations.
+   */
+  protected def withSQLConf[T](pairs: (String, String)*)(f: => T): T = {

Review Comment:
   Oh, this looks like an independent contribution too. Sorry for asking this again, but could you spin-off this too?
   
   The new PR title could be the following, @ulysses-you .
   ```
   Move `withSQLConf` from SQLHelper trait to `SQLConfHelper` trait
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org