Re: [PR] [SPARK-52403][SQL] Add metric to MergeRowExec for rows that do not match condition [spark]

["szehon-ho (via GitHub)" <gi...@apache.org>]

szehon-ho commented on code in PR #51091:
URL: https://github.com/apache/spark/pull/51091#discussion_r2155538969


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/MergeRowsExec.scala:
##########
@@ -69,6 +71,13 @@ case class MergeRowsExec(
     copy(child = newChild)
   }
 
+  override lazy val metrics: Map[String, SQLMetric] = Map(
+    "numTargetRowsCopied" -> SQLMetrics.createMetric(sparkContext,
+      "Number of target rows copied over because they did not match any condition."),
+    "numTargetRowsUnmatched" -> SQLMetrics.createMetric(sparkContext,
+      "Number of target rows processed that do not match any condition. " +
+        "These will be dropped for delta-based merge and retained for group-based merge."))

Review Comment:
   actually, to me unused is a bit wrong because we do use it (we copy it).  is unchanged ok?  I didnt see the ambiguity.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org