You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tzulitai <gi...@git.apache.org> on 2017/07/11 17:41:46 UTC

[GitHub] flink pull request #4302: (master) [FLINK-7143] [kafka] Stricter tests for d...

GitHub user tzulitai opened a pull request:

    https://github.com/apache/flink/pull/4302

    (master) [FLINK-7143] [kafka] Stricter tests for deterministic partition assignment

    This is the forward port of the fix in #4301. The `master` branch does not require a fix, because the new `AbstractPartitionDiscoverer` already correctly uses `partition.hashCode % numTasks` for the partition discovery filtering.
    
    This PR simply makes the tests for partition assignment more strict, to guard against breaking deterministic assignment in the future.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzulitai/flink FLINK-7143-master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4302.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4302
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4302: (master) [FLINK-7143] [kafka] Stricter tests for determin...

Posted by tzulitai <gi...@git.apache.org>.

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/4302
  
    Merging :) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4302: (master) [FLINK-7143] [kafka] Stricter tests for d...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4302


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4302: (master) [FLINK-7143] [kafka] Stricter tests for determin...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4302
  
    @tzulitai You can merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---