You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/11/30 10:29:16 UTC
[GitHub] [camel] JiriOndrusek opened a new pull request #4702: CAMEL-15879 Update avro version to 1.10.x (1.10.0)
JiriOndrusek opened a new pull request #4702:
URL: https://github.com/apache/camel/pull/4702
fixes: https://issues.apache.org/jira/browse/CAMEL-15879
Upgrade to newer avro brings change from netty3 to netty4. This brings graceful connection closing, which takes longer time (it takes about 4 seconds - https://github.com/apache/avro/commit/d2d5663076d9c4a5b92b7102a21217a5c8cf6115#diff-3b49ec5d308d4a1ed5a80c9c41fc6c5c2173985033470c6531a9a1fb93a72edaR111). I've refactored test to minimize number of netty connection closes. Even with thisd optimization, there is need to close netty server 36 times (for all tests in the module).
Which means that the time taken by all the tests is much higher. On my local computer it takes **0:29** before upgrade and **2:44** after upgrade. I'm not sure whether it is acceptable or if some tests should be moved among slower tests.
**Unfortunately it is not possible to update karaf feature.** `avro-ipc-jetty` requires javax.servlet.api >= 4.0 and also jetty server. But there is no jetty server available as karaf feature which is using servlet-api >= 4.0. I'm removing karaf feature (based on [comment](https://issues.apache.org/jira/browse/CAMEL-15879?focusedCommentId=17239692&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17239692) (camel-karaf [PR](https://github.com/apache/camel-karaf/pull/55))
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #4702: CAMEL-15879 Update avro version to 1.10.x (1.10.0)
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #4702:
URL: https://github.com/apache/camel/pull/4702
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org