You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "dawidwys (via GitHub)" <gi...@apache.org> on 2023/09/26 10:49:43 UTC

[GitHub] [flink] dawidwys opened a new pull request, #23468: [FLINK-33158] Cryptic exception when there is a StreamExecSort in JsonPlan

dawidwys opened a new pull request, #23468:
URL: https://github.com/apache/flink/pull/23468

   ## What is the purpose of the change
   
   Properly serialises `StreamExecSort` into JsonPlan. Even though `StreamExecSort` is not supported for production workloads, without the change it fails during plan deserialisation which gives a cryptic error message.
   
   ## Verifying this change
   
   Added test in `org.apache.flink.table.planner.plan.nodes.exec.stream.SortJsonPlanTest#testSort`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (**yes** / no / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #23468: [FLINK-33158] Cryptic exception when there is a StreamExecSort in JsonPlan

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23468:
URL: https://github.com/apache/flink/pull/23468#issuecomment-1735300775

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ed662d6badffd872673f5034f7d59fe8c0ef4022",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ed662d6badffd872673f5034f7d59fe8c0ef4022",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ed662d6badffd872673f5034f7d59fe8c0ef4022 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33158] Cryptic exception when there is a StreamExecSort in JsonPlan [flink]

Posted by "dawidwys (via GitHub)" <gi...@apache.org>.
dawidwys commented on PR #23468:
URL: https://github.com/apache/flink/pull/23468#issuecomment-1744888627

   Good point. I'll merge this since it is an improvement for `StreamExecSort`. I'll work for a more generic solution for serialisation issues in the `ExecNodeGraph` in https://issues.apache.org/jira/browse/FLINK-33179


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33158] Cryptic exception when there is a StreamExecSort in JsonPlan [flink]

Posted by "dawidwys (via GitHub)" <gi...@apache.org>.
dawidwys merged PR #23468:
URL: https://github.com/apache/flink/pull/23468


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org