You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jeff Trawick <tr...@gmail.com> on 2013/08/13 17:01:53 UTC
Re: svn commit: r1513508 - /httpd/httpd/trunk/modules/proxy/proxy_util.c
On Tue, Aug 13, 2013 at 10:35 AM, <dr...@apache.org> wrote:
> Author: druggeri
> Date: Tue Aug 13 14:35:47 2013
> New Revision: 1513508
>
> URL: http://svn.apache.org/r1513508
> Log:
> UDS subsequent request on a connection fix
>
> Modified:
> httpd/httpd/trunk/modules/proxy/proxy_util.c
>
> Modified: httpd/httpd/trunk/modules/proxy/proxy_util.c
> URL:
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/proxy_util.c?rev=1513508&r1=1513507&r2=1513508&view=diff
>
> ==============================================================================
> --- httpd/httpd/trunk/modules/proxy/proxy_util.c (original)
> +++ httpd/httpd/trunk/modules/proxy/proxy_util.c Tue Aug 13 14:35:47 2013
> @@ -2119,7 +2119,7 @@ ap_proxy_determine_connection(apr_pool_t
> * spilling the cached addr from the worker.
> */
> if (!conn->hostname || !worker->s->is_address_reusable ||
> - worker->s->disablereuse) {
> + worker->s->disablereuse || strncmp(conn->hostname, "socket=", 7)
> == 0) {
>
I guess this means FastCGI connections can't be reused regardless of the
configuration? (That doesn't seem like a good thing; maybe users should
have to configure disablereuse if reuse doesn't work for them.)
I guess you need to turn off FCGI_KEEP_CONN in send_begin_request() if
reuse is always disabled?
> if (proxyname) {
> conn->hostname = apr_pstrdup(conn->pool, proxyname);
> conn->port = proxyport;
>
>
>
--
Born in Roswell... married an alien...
http://emptyhammock.com/
Re: svn commit: r1513508 - /httpd/httpd/trunk/modules/proxy/proxy_util.c
Posted by Jeff Trawick <tr...@gmail.com>.
On Tue, Aug 13, 2013 at 9:00 PM, Daniel Ruggeri <DR...@primary.net>wrote:
> On 8/13/2013 10:01 AM, Jeff Trawick wrote:
> >
> > --- httpd/httpd/trunk/modules/proxy/proxy_util.c (original)
> > +++ httpd/httpd/trunk/modules/proxy/proxy_util.c Tue Aug 13
> > 14:35:47 2013
> > @@ -2119,7 +2119,7 @@ ap_proxy_determine_connection(apr_pool_t
> > * spilling the cached addr from the worker.
> > */
> > if (!conn->hostname || !worker->s->is_address_reusable ||
> > - worker->s->disablereuse) {
> > + worker->s->disablereuse || strncmp(conn->hostname,
> > "socket=", 7) == 0) {
> >
> >
> > I guess this means FastCGI connections can't be reused regardless of
> > the configuration? (That doesn't seem like a good thing; maybe users
> > should have to configure disablereuse if reuse doesn't work for them.)
> >
> > I guess you need to turn off FCGI_KEEP_CONN in send_begin_request() if
> > reuse is always disabled?
>
> Jeff;
> I'm not sure I follow - can you help me understand how this messes
> with fcgi? As I understand, it wouldn't match what this string
> comparison is seeking... right?
>
"socket=" is one form of FastCGI, and and I misunderstood this logic to be
adjusting the ability to reuse the connection instead of reusing an address.
Sorry for the bother !!!
> --
> Daniel Ruggeri
>
>
>
>
--
Born in Roswell... married an alien...
http://emptyhammock.com/
Re: svn commit: r1513508 - /httpd/httpd/trunk/modules/proxy/proxy_util.c
Posted by Daniel Ruggeri <DR...@primary.net>.
On 8/13/2013 10:01 AM, Jeff Trawick wrote:
>
> --- httpd/httpd/trunk/modules/proxy/proxy_util.c (original)
> +++ httpd/httpd/trunk/modules/proxy/proxy_util.c Tue Aug 13
> 14:35:47 2013
> @@ -2119,7 +2119,7 @@ ap_proxy_determine_connection(apr_pool_t
> * spilling the cached addr from the worker.
> */
> if (!conn->hostname || !worker->s->is_address_reusable ||
> - worker->s->disablereuse) {
> + worker->s->disablereuse || strncmp(conn->hostname,
> "socket=", 7) == 0) {
>
>
> I guess this means FastCGI connections can't be reused regardless of
> the configuration? (That doesn't seem like a good thing; maybe users
> should have to configure disablereuse if reuse doesn't work for them.)
>
> I guess you need to turn off FCGI_KEEP_CONN in send_begin_request() if
> reuse is always disabled?
Jeff;
I'm not sure I follow - can you help me understand how this messes
with fcgi? As I understand, it wouldn't match what this string
comparison is seeking... right?
--
Daniel Ruggeri