You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2017/08/04 21:57:47 UTC
[GitHub] incubator-guacamole-website pull request #46: GUACAMOLE-259: Add required li...
GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-website/pull/46
GUACAMOLE-259: Add required links to ASF resources.
From Dave Fisher:
>
> Hello Guacamole,
>
> I volunteered to shepherd your report for the IPMC. It does look like you are near graduation. Congratulations!
>
> I did notice something that you should correct on your website. You don't have good links back the ASF.
>
> Please see https://www.apache.org/foundation/marks/pmcs#navigation
>
> Regards,
> Dave
>
Specifically, from the link referenced above:
>
> ### WEBSITE NAVIGATION LINKS POLICY
>
> Whatever main navigation system your project website uses, it must feature certain text links back to key pages on the main www.apache.org website. These links can appear in whatever main navigation system your site uses on all top level pages for the project or subproject.
>
> * "License" should link to: http://www.apache.org/licenses/
> * "Sponsorship" or "Donate" should link to: http://www.apache.org/foundation/sponsorship.html
> * "Thanks" should link to: http://www.apache.org/foundation/thanks.html
> * "Security" should link to either to a project-specific page detailing how users may securely report potential vulnerabilities, or to the main http://www.apache.org/security/ page
> * All projects must feature some prominent link back to the main ASF homepage at http://www.apache.org/
>
> **Link back to www.apache.org:** All project and subproject homepages must include a prominent link to the main http://www.apache.org homepage. This may either be a featured link in your main navigation system, or may be a text link in your Main homepage text. A best practice is to include a short sentence or paragraph on the homepage noting that this project is an Apache project, and is part of a larger community of developers and users.
>
> If you have alternate suggestions for the text for links pointing back to the main ASF pages that better fit with your project's web presence, please let trademarks@ know.
>
> **Including "Thanks" links to third parties** - if your project has typically companies that donate software licenses or support to project committers, please follow the [Corporate Recognition Guidelines](https://www.apache.org/foundation/marks/linking). It is important to ensure any such pages are presented publicly in a manner that is distinctly different than the formal Sponsorship program.
>
This change refactors the navigation menu of the Apache Guacamole website, adding support for nested menus, and reorganizing things such that there can be a submenu containing links to required ASF resources:
The submenus are controlled through JavaScript (simplified a bit via jQuery) and open/close through clicks:
The required ASF links are within the far right menu, with the exception of the "Security" link (which should probably be as obvious as possible to avoid security issues being reported using inappropriate public channels):
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-website apache-links
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-website/pull/46.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #46
----
commit 5713a8abcceca7f953980bfa4002aac6c3ba1498
Author: Michael Jumper <mj...@apache.org>
Date: 2017-08-04T19:16:05Z
GUACAMOLE-359: Use explicit menu links for all pages.
commit 7db6f6b12bbcdddbd249ba0e0dfc8ec6e68be258
Author: Michael Jumper <mj...@apache.org>
Date: 2017-08-04T19:59:14Z
GUACAMOLE-359: Add support for nested menus.
commit 00eda50d290fe74f5d4fd3a69ac86676d9daa00e
Author: Michael Jumper <mj...@apache.org>
Date: 2017-08-04T21:12:06Z
GUACAMOLE-359: Migrate existing pages to nested menu structure.
commit c51580189a2799c3f314c7cbdf0588c30e696bbf
Author: Michael Jumper <mj...@apache.org>
Date: 2017-08-04T21:25:12Z
GUACAMOLE-359: Add links to ASF pages.
commit 67b0d1ee32e4ab4beb990e8b6f9fd44ce499666c
Author: Michael Jumper <mj...@apache.org>
Date: 2017-08-04T21:28:06Z
GUACAMOLE-359: Move "Security" link to top level.
commit 7dea4132c9e0c589dc11c86cc5d76bd95ae72b04
Author: Michael Jumper <mj...@apache.org>
Date: 2017-08-04T21:41:46Z
GUACAMOLE-359: Add feather to ASF link menu.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-website pull request #46: GUACAMOLE-359: Add required li...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-website/pull/46
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---