You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/01/27 00:51:42 UTC

[GitHub] [maven-surefire] kriegaex commented on a change in pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

kriegaex commented on a change in pull request #332:
URL: https://github.com/apache/maven-surefire/pull/332#discussion_r564941015



##########
File path: maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/extensions/StreamFeederTest.java
##########
@@ -90,9 +91,9 @@ public void shouldEncodeCommandToStream() throws Exception
                 public Object answer( InvocationOnMock invocation ) throws IOException
                 {
                     ByteBuffer bb = invocation.getArgument( 0 );

Review comment:
       `bb.array()` two lines further down would then return `Object` instead of `byte[]` which would mean a cast in that place instead. Is that preferable in your opinion?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org