You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "liferoad (via GitHub)" <gi...@apache.org> on 2024/06/05 15:10:56 UTC
[PR] added the label option for ReadFromCsv [beam]
liferoad opened a new pull request, #31511:
URL: https://github.com/apache/beam/pull/31511
This could avoid the duplicated labels when using ReadFromCsv several times in the pipeline.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DO NOT MERGE YET] added the label option for ReadFromCsv [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad closed pull request #31511: [DO NOT MERGE YET] added the label option for ReadFromCsv
URL: https://github.com/apache/beam/pull/31511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] added the label option for ReadFromCsv [beam]
Posted by "aaltay (via GitHub)" <gi...@apache.org>.
aaltay commented on code in PR #31511:
URL: https://github.com/apache/beam/pull/31511#discussion_r1628066608
##########
sdks/python/apache_beam/io/textio.py:
##########
@@ -927,7 +927,12 @@ def append(dest):
@append_pandas_args(
pandas.read_csv, exclude=['filepath_or_buffer', 'iterator'])
- def ReadFromCsv(path: str, *, splittable: bool = True, **kwargs):
+ def ReadFromCsv(
+ path: str,
+ *,
+ splittable: bool = True,
+ label: str = 'ReadFromCsv',
Review Comment:
Would not this be backward incompatible if **kwargs already has a label key?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DO NOT MERGE YET] added the label option for ReadFromCsv [beam]
Posted by "aaltay (via GitHub)" <gi...@apache.org>.
aaltay commented on PR #31511:
URL: https://github.com/apache/beam/pull/31511#issuecomment-2151026231
I did not realize that right-shift label overriding was broken for some transforms. I agree that it will be a better fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DO NOT MERGE YET] added the label option for ReadFromCsv [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #31511:
URL: https://github.com/apache/beam/pull/31511#issuecomment-2151101534
Agree. Close this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] added the label option for ReadFromCsv [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31511:
URL: https://github.com/apache/beam/pull/31511#issuecomment-2150439644
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label python.
R: @Abacn for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] added the label option for ReadFromCsv [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #31511:
URL: https://github.com/apache/beam/pull/31511#issuecomment-2150854140
> This is making an API change only for one transform without making this a uniform change across the board. I found that state of non-consistent API more confusing then having this same thing either everywhere or nowhere.
I agree with you. I am open to not do this at all. But I want to put the PR here to discuss this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] added the label option for ReadFromCsv [beam]
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb commented on PR #31511:
URL: https://github.com/apache/beam/pull/31511#issuecomment-2150364068
Wouldn't it be preferable to support the `label >> ReadFromCsv(...)` syntax for consistency with all other transforms?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DO NOT MERGE YET] added the label option for ReadFromCsv [beam]
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb commented on PR #31511:
URL: https://github.com/apache/beam/pull/31511#issuecomment-2150920941
See https://github.com/apache/beam/pull/31522 which will allow `"CustomLabel" >> ReadFromCsv(...)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] added the label option for ReadFromCsv [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on code in PR #31511:
URL: https://github.com/apache/beam/pull/31511#discussion_r1628364500
##########
sdks/python/apache_beam/io/textio.py:
##########
@@ -927,7 +927,12 @@ def append(dest):
@append_pandas_args(
pandas.read_csv, exclude=['filepath_or_buffer', 'iterator'])
- def ReadFromCsv(path: str, *, splittable: bool = True, **kwargs):
+ def ReadFromCsv(
+ path: str,
+ *,
+ splittable: bool = True,
+ label: str = 'ReadFromCsv',
Review Comment:
yes, but I doubt users actually do that now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org