You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by sokac <gi...@git.apache.org> on 2017/07/13 01:25:45 UTC
[GitHub] thrift pull request #1307: THRIFT-4248: Import cstring in TSSLSocket
GitHub user sokac opened a pull request:
https://github.com/apache/thrift/pull/1307
THRIFT-4248: Import cstring in TSSLSocket
strncpy, memcmp, memset are used in TSSLSocket so cstring needs to be
imported.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sokac/thrift fix/lib_cpp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1307.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1307
----
commit f2f235001c07b9be81cf3a12518533ce28767db0
Author: Josip Sokcevic <in...@sokac.net>
Date: 2017-07-08T23:34:49Z
THRIFT-4248: Import cstring in TSSLSocket
strncpy, memcmp, memset are used in TSSLSocket so cstring needs to be
imported.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1307: THRIFT-4248: Import cstring in TSSLSocket
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1307
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1307: THRIFT-4248: Import cstring in TSSLSocket
Posted by sokac <gi...@git.apache.org>.
Github user sokac commented on the issue:
https://github.com/apache/thrift/pull/1307
Correct, <string> is not the same as <string.h>. However, <cstring> (C++) is very similar to <string.h> (C), with only difference that cstring is part of std and usually preferred for C++
https://stackoverflow.com/questions/8380805/difference-between-string-h-and-cstring
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---