You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/05/27 13:45:56 UTC
Review Request: SQOOP-1060 Sqoop2: Increase maximal size of custom query in
Generic JDBC Connector
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11434/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
I've increased the limit to 2000.
This addresses bug SQOOP-1060.
https://issues.apache.org/jira/browse/SQOOP-1060
Diffs
-----
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ExportTableForm.java ee4bb6e57d1abcc4a9269d93e6384d9f2c315a1c
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportTableForm.java 3422a8fa28c0a594e4eb454f46fe73f6760d81ba
Diff: https://reviews.apache.org/r/11434/diff/
Testing
-------
Unit and integration test seems to be working.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-1060 Sqoop2: Increase maximal size of custom query
in Generic JDBC Connector
Posted by Kathleen Ting <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11434/#review21904
-----------------------------------------------------------
Ship it!
Ship It!
- Kathleen Ting
On May 27, 2013, 11:45 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11434/
> -----------------------------------------------------------
>
> (Updated May 27, 2013, 11:45 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've increased the limit to 2000.
>
>
> This addresses bug SQOOP-1060.
> https://issues.apache.org/jira/browse/SQOOP-1060
>
>
> Diffs
> -----
>
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ExportTableForm.java ee4bb6e57d1abcc4a9269d93e6384d9f2c315a1c
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportTableForm.java 3422a8fa28c0a594e4eb454f46fe73f6760d81ba
>
> Diff: https://reviews.apache.org/r/11434/diff/
>
>
> Testing
> -------
>
> Unit and integration test seems to be working.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request: SQOOP-1060 Sqoop2: Increase maximal size of custom query
in Generic JDBC Connector
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11434/#review21070
-----------------------------------------------------------
Ship it!
Thanks Jarek. Yes, we need to have at least 2000 characters.
- Venkat Ranganathan
On May 27, 2013, 11:45 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11434/
> -----------------------------------------------------------
>
> (Updated May 27, 2013, 11:45 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've increased the limit to 2000.
>
>
> This addresses bug SQOOP-1060.
> https://issues.apache.org/jira/browse/SQOOP-1060
>
>
> Diffs
> -----
>
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ExportTableForm.java ee4bb6e57d1abcc4a9269d93e6384d9f2c315a1c
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportTableForm.java 3422a8fa28c0a594e4eb454f46fe73f6760d81ba
>
> Diff: https://reviews.apache.org/r/11434/diff/
>
>
> Testing
> -------
>
> Unit and integration test seems to be working.
>
>
> Thanks,
>
> Jarek Cecho
>
>