You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/12/20 13:10:26 UTC
[GitHub] zentol opened a new pull request #7345: [FLINK-11163][tests] Use
random port in RestClusterClientTest
zentol opened a new pull request #7345: [FLINK-11163][tests] Use random port in RestClusterClientTest
URL: https://github.com/apache/flink/pull/7345
## What is the purpose of the change
This PR fixes a port conflict in the `RestClusterClientTest`. The test was starting a rest server in each test on a single fixed port. The port is now random, but since each test creates a separate rest server each of them runs on a different port, so we need a different RestClusterClient for each of them.
Basically all i did was create a new RestClusterClient in the `try (RestServerEndpoint..)` blocks, and wrap the assertions in a `try-finally` block to ensure shutdown of the client.
Additionally this PR also contains a hotfix that removes mocking from the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services