[GitHub] [spark] vanzin commented on a change in pull request #26616: [SPARK-25392][CORE][WEBUI] Prevent error page when accessing pools page from history server

[GitBox <gi...@apache.org>]

vanzin commented on a change in pull request #26616: [SPARK-25392][CORE][WEBUI] Prevent error page when accessing pools page from history server
URL: https://github.com/apache/spark/pull/26616#discussion_r358394391
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/ui/jobs/AllStagesPage.scala
 ##########
 @@ -30,7 +30,8 @@ import org.apache.spark.ui.{UIUtils, WebUIPage}
 private[ui] class AllStagesPage(parent: StagesTab) extends WebUIPage("") {
   private val sc = parent.sc
   private val subPath = "stages"
-  private def isFairScheduler = parent.isFairScheduler
+  // Show pool information for only live UI
+  private def isFairScheduler = sc.isDefined && parent.isFairScheduler
 
 Review comment:
   It would be better to fix `StageTab.isFairScheduler` and remove this method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org