You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Ken Giusti (Jira)" <ji...@apache.org> on 2021/05/18 20:01:00 UTC
[jira] [Created] (DISPATCH-2133) qd_log_enabled() race
Ken Giusti created DISPATCH-2133:
------------------------------------
Summary: qd_log_enabled() race
Key: DISPATCH-2133
URL: https://issues.apache.org/jira/browse/DISPATCH-2133
Project: Qpid Dispatch
Issue Type: Bug
Components: Router Node
Affects Versions: 1.16.0
Reporter: Ken Giusti
Assignee: Ken Giusti
Fix For: 1.17.0
TSAN flags qd_log_enabled() as a race since it reads the source mask without holding the source lock.
Mostly harmless - adding synchronizing overhead not likely worth it.
Masking qd_log_enabled() for now.
20: WARNING: ThreadSanitizer: data race (pid=637946)
20: Write of size 4 at 0x7b1c00000018 by main thread (mutexes: write M13, write M11):
20: #0 qd_log_entity /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:634 (libqpid-dispatch.so+0x8dbe0)
20: #1 ffi_call_unix64 <null> (libffi.so.6+0x6aef)
20: #2 qdr_forward_on_message /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/forwarder.c:336 (libqpid-dispatch.so+0xe4ff5)
20: #3 qdr_general_handler /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core.c:929 (libqpid-dispatch.so+0xf83f6)
20: #4 qd_timer_visit /home/kgiusti/work/dispatch/qpid-dispatch/src/timer.c:317 (libqpid-dispatch.so+0x135b52)
20: #5 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1006 (libqpid-dispatch.so+0x12fc8d)
20: #6 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 (libqpid-dispatch.so+0x13063a)
20: #7 qd_server_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1501 (libqpid-dispatch.so+0x1328de)
20: #8 main_process /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:115 (qdrouterd+0x40271a)
20: #9 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x403557)
20:
20: Previous read of size 4 at 0x7b1c00000018 by thread T2:
20: #0 qd_log_enabled /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:404 (libqpid-dispatch.so+0x8cb49)
20: #1 transport_tracer /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:111 (libqpid-dispatch.so+0x12ac43)
20: #2 pni_tracer_to_log_sink /home/kgiusti/work/proton/qpid-proton/c/src/core/transport.c:2874 (libqpid-proton-core.so.10+0x22185)
20: #3 _thread_init /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0xad37a)
20: #4 <null> <null> (libtsan.so.0+0x2d33f)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org