You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/09/19 22:52:30 UTC

[GitHub] [druid] 317brian opened a new pull request, #13127: fix: follow naming convention for msq task engine

317brian opened a new pull request, #13127:
URL: https://github.com/apache/druid/pull/13127

   This PR has:
   - [x] been self-reviewed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] gianm commented on a diff in pull request #13127: fix: follow naming convention for msq task engine

Posted by GitBox <gi...@apache.org>.
gianm commented on code in PR #13127:
URL: https://github.com/apache/druid/pull/13127#discussion_r975693142


##########
docs/multi-stage-query/api.md:
##########
@@ -48,7 +48,7 @@ The SQL task endpoint accepts [SQL requests in the JSON-over-HTTP form](../query
 
 This endpoint accepts [INSERT](reference.md#insert) and [REPLACE](reference.md#replace) statements.
 
-As an experimental feature, this endpoint also accepts SELECT queries. SELECT query results are collected from workers

Review Comment:
   agreed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] 317brian commented on a diff in pull request #13127: fix: follow naming convention for msq task engine

Posted by GitBox <gi...@apache.org>.
317brian commented on code in PR #13127:
URL: https://github.com/apache/druid/pull/13127#discussion_r975716029


##########
docs/multi-stage-query/api.md:
##########
@@ -48,7 +48,7 @@ The SQL task endpoint accepts [SQL requests in the JSON-over-HTTP form](../query
 
 This endpoint accepts [INSERT](reference.md#insert) and [REPLACE](reference.md#replace) statements.
 
-As an experimental feature, this endpoint also accepts SELECT queries. SELECT query results are collected from workers

Review Comment:
   Got it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] vogievetsky commented on pull request #13127: fix: follow naming convention for msq task engine

Posted by GitBox <gi...@apache.org>.
vogievetsky commented on PR #13127:
URL: https://github.com/apache/druid/pull/13127#issuecomment-1253268620

   you need to update an anchor:
   
   <img width="1149" alt="image" src="https://user-images.githubusercontent.com/177816/191431625-d1b149d8-5ef2-41d3-a0df-3c40ddd114a9.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] gianm commented on a diff in pull request #13127: fix: follow naming convention for msq task engine

Posted by GitBox <gi...@apache.org>.
gianm commented on code in PR #13127:
URL: https://github.com/apache/druid/pull/13127#discussion_r975677069


##########
docs/multi-stage-query/index.md:
##########
@@ -33,7 +33,7 @@ This extension adds a [multi-stage query task engine for SQL](concepts.md#sql-ta
 [INSERT](concepts.md#insert) and [REPLACE](concepts.md#replace) statements as batch tasks. As an experimental feature,
 the task engine also supports running SELECT queries as batch tasks.
 
-Nearly all SELECT capabilities are available in the SQL task engine, with certain exceptions listed on the [Known
+Nearly all SELECT capabilities are available in the multi-stage query (MSQ) task engine, with certain exceptions listed on the [Known

Review Comment:
   Could you please make the same edit in `api.md`? There's some very similar language there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] vogievetsky merged pull request #13127: fix: follow naming convention for msq task engine

Posted by GitBox <gi...@apache.org>.
vogievetsky merged PR #13127:
URL: https://github.com/apache/druid/pull/13127


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] vogievetsky commented on a diff in pull request #13127: fix: follow naming convention for msq task engine

Posted by GitBox <gi...@apache.org>.
vogievetsky commented on code in PR #13127:
URL: https://github.com/apache/druid/pull/13127#discussion_r975692618


##########
docs/multi-stage-query/api.md:
##########
@@ -48,7 +48,7 @@ The SQL task endpoint accepts [SQL requests in the JSON-over-HTTP form](../query
 
 This endpoint accepts [INSERT](reference.md#insert) and [REPLACE](reference.md#replace) statements.
 
-As an experimental feature, this endpoint also accepts SELECT queries. SELECT query results are collected from workers

Review Comment:
   I think it is best to keep the `As an experimental feature,` language since the SELECT queries part is experimental



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org