You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/03/02 18:51:26 UTC
[GitHub] couchdb-fauxton pull request: Detect system databases on _
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/299
Detect system databases on _
All system databases are now prefixed by `_`, so we can remove
a lot of detection logic.
Additionally colored the warning in red.
closes COUCHDB-2607
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton COUCHDB-2607-is-system-db
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/299.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #299
----
commit c2646568418c5bffbe659f3b4f24d70c4258a245
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-03-02T17:43:00Z
Detect system databases on _
All system databases are now prefixed by `_`, so we can remove
a lot of detection logic.
Additionally colored the warning in red.
closes COUCHDB-2607
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Detect system databases on _
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/299#issuecomment-76763679
LGFM. Few questions:
1. Shouldn't Database mode have a property `isSystemDatabase` which encapsulates logic about how this determines?
2. Shouldn't Fauxton instead of warn about deletion system database completely prevent this action? Synthetic restriction, but will definitely save users from shooting them self in the foot.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Detect system databases on _
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/299#issuecomment-76772210
@robertkowalski hm...that's definitely a bad use case, some sort of problem workaround. Worth to look on this problem closely. But that's beyond of this PR (:
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Detect system databases on _
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/299#issuecomment-76944181
merged as 4b3b73f44349230ea8ae3a877f4c2e2a87258d9d :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Detect system databases on _
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/299#issuecomment-76767368
@kxepal i'll ask some folks regarding that second point
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Detect system databases on _
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/299#issuecomment-76765459
good points!
1. fixed, you are right
2. hmmm... I think we should allow it as it, I often delete my system dbs, e.g. _replicator
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Detect system databases on _
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/299
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Detect system databases on _
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/299#issuecomment-76767307
@robertkowalski yea, killing _replicator and _users is safe, but I'm very sceptical that _dbs, _nodes and _metadata would be too. Anyway, just thinking loudly, worth to check this moment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Detect system databases on _
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/299#issuecomment-76768498
@kxepal got feedback, they say the users should be able to delete them, as sometimes replications start failing so badly that there's no way to delete it by rev or even PID and just deleting the _replicator db helps in those cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Detect system databases on _
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/299#issuecomment-76873450
+1 after you change app/addons/databases/resources.js: 53 to `return (/^_/).test(this.id);`
btw, pretty neat @robertkowalski !
:D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---