[GitHub] [flink] StephanEwen commented on a change in pull request #10449: [FLINK-7289][state-backend] Integrate RocksDB memory use with managed memory

[GitBox <gi...@apache.org>]

StephanEwen commented on a change in pull request #10449: [FLINK-7289][state-backend] Integrate RocksDB memory use with managed memory
URL: https://github.com/apache/flink/pull/10449#discussion_r354755071
 
 

 ##########
 File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOptions.java
 ##########
 @@ -86,4 +86,42 @@
 				"The default options factory is %s, and it would read the configured options which provided in 'RocksDBConfigurableOptions'.",
 				DefaultConfigurableOptionsFactory.class.getName()));
 
+	public static final ConfigOption<Boolean> USE_MANAGED_MEMORY = ConfigOptions
+		.key("state.backend.rocksdb.memory.managed")
+		.booleanType()
+		.defaultValue(false)
+		.withDescription("If set, the RocksDB state backend will automatically configure itself to use the " +
+			"managed memory budget of the task slot, and divide the memory over write buffers, indexes, " +
+			"block caches, etc. That way, the state backend will not exceed the available memory, but use as much " +
+			"memory as it can.");
+
+	public static final ConfigOption<Long> FIX_PER_SLOT_MEMORY_SIZE = ConfigOptions
 
 Review comment:
   +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services