You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/08 09:20:42 UTC
[GitHub] [incubator-superset] ktmud opened a new pull request #9490: [Build]
Add Github workflows
ktmud opened a new pull request #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490
### CATEGORY
- [x] Build / Development Environment
### SUMMARY
Test adding GitHub Actions per discussion in https://github.com/apache/incubator-superset/issues/9481.
There are certain limitations with Github Actions, e.g., no DAG support, can't cancel current jobs on new push, etc., but overall it was a nice experience.
This is a pure addition to current build process. Nothing changes for Travis CI, except Cypress is now upgraded from 3.6.1 to 3.8.3.
I've tried to parallelize jobs as much as I can, but there's definitely more room for improvement, especially with the Cypress end to end tests.
A new GitHub Action was created to generalize some of the steps, but we could potentially move more things there. For example, the caching steps can also be extracted to the action script, similar to what the official Cypress action did:
https://github.com/cypress-io/github-action/blob/d81aef503fcd11db601c9f79ca30d3353dcc46e9/index.js#L8
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
### TEST PLAN
Make sure CI check pass.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9490: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#discussion_r406010027
##########
File path: superset-frontend/cypress-base/cypress.json
##########
@@ -1,13 +1,14 @@
{
"baseUrl": "http://localhost:8081",
"chromeWebSecurity": false,
- "defaultCommandTimeout": 20000,
- "requestTimeout": 20000,
- "ignoreTestFiles": ["**/!(*.test.js)"],
- "projectId": "fbf96q",
+ "defaultCommandTimeout": 5000,
+ "requestTimeout": 10000,
+ "ignoreTestFiles": [
+ "**/!(*.test.js)"
+ ],
"video": false,
"videoUploadOnPasses": false,
"viewportWidth": 1280,
"viewportHeight": 800,
- "requestTimeout": 10000
+ "projectId": "dk2opw"
Review comment:
Updated to a project under my personal account for testing. Will need to change back to [the official project ](https://dashboard.cypress.io/projects/fbf96q/runs) once merged.
Please [add a new record key](https://docs.cypress.io/guides/dashboard/projects.html#Set-up-a-project-to-record) to [GitHub Actions secrets](https://help.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets) under the name `CYPRESS_RECORD_KEY`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9490: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#discussion_r405990497
##########
File path: .github/workflows/superset-e2e.yml
##########
@@ -0,0 +1,78 @@
+name: E2E
+
+on:
+ push:
+ branches: [ master ]
+ pull_request:
+
+jobs:
+ cypress:
+ name: Cypress
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ python-version: [3.6]
+ env:
+ SUPERSET_CONFIG: tests.superset_test_config
+ PYTHONPATH: ${{ github.workspace }}
+ REDIS_PORT: 16379
+ CI: github-actions
+ CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ services:
+ redis:
+ image: redis:5-alpine
+ ports:
+ - 16379:6379
Review comment:
GitHub-hosted action runners [have some softwares pre-installed](https://help.github.com/en/actions/reference/software-installed-on-github-hosted-runners), including MySQL, Redis, and PostgreSQL.
Here we map all database services to a new port to make sure we don't accidentally use the build-in services that _may_ be running on default ports already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9490: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#discussion_r406021386
##########
File path: superset-frontend/cypress-base/cypress.json
##########
@@ -1,13 +1,14 @@
{
"baseUrl": "http://localhost:8081",
"chromeWebSecurity": false,
- "defaultCommandTimeout": 20000,
Review comment:
No need to actually wait for 20s for default commands (e.g., click triggers).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9490: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#discussion_r406011901
##########
File path: superset-frontend/cypress-base/cypress/integration/dashboard/edit_mode.js
##########
@@ -75,7 +75,7 @@ export default () =>
.trigger('mousedown', { which: 1 })
.trigger('dragstart', { dataTransfer })
.trigger('drag', {});
- cy.get('.grid-content .dragdroppable')
+ cy.get('.grid-content div.grid-row.background--transparent')
Review comment:
The upgraded Cypress will error out because it was dragged to a zero-height element. This fixes the error by dragging to the last visible row instead of the invisible one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request
#9490: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#discussion_r405575675
##########
File path: .github/workflows/superset.yml
##########
@@ -0,0 +1,205 @@
+name: Superset
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+ # but also build on pull requests to any branch
+ # (the so-called feature branch)
+ pull_request:
+ paths:
+ - superset/**/*.py
+ - tests/**
Review comment:
Should this include `superset-frontend/**` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on issue #9490: [Build] Add
Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#issuecomment-611787741
Woking on further improvements, closing for now to avoid excessive notification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on issue #9490: [Build] Add
Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#issuecomment-610852607
See the builds in action: https://github.com/ktmud/incubator-superset/pull/25
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #9490: [Build]
Add Github workflows
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#issuecomment-612122843
Hey @ktmud - let us know if there's anything we at Preset can do to support you on this work. We're really feeling the Travis pain and want to help get to a solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9490: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#discussion_r405988497
##########
File path: .github/actions/setup-superset/action.yml
##########
@@ -0,0 +1,17 @@
+name: Setup Superset
+description: Setup the CI/test envrionment for Apache Superset
+author: Jesse Yang <he...@yjc.me>
+inputs:
+ prepare:
+ required: false
+ description: prepare commands, one or more of (backend, frontend, mysql, postgres)
+ default: backend
+ run:
+ required: false
+ description: additional commands to run
+ parallel:
+ required: false
+ description: whether to run additional commands in parallel
Review comment:
The `parallel` mode is not currently in use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9490: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#discussion_r405618955
##########
File path: .github/workflows/superset.yml
##########
@@ -0,0 +1,205 @@
+name: Superset
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+ # but also build on pull requests to any branch
+ # (the so-called feature branch)
+ pull_request:
+ paths:
+ - superset/**/*.py
+ - tests/**
Review comment:
This file is purely for python code. Frontend code checks are done in other workflows. Maybe I this rename this file to avoid confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9490: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#discussion_r406064210
##########
File path: superset-frontend/cypress-base/cypress/integration/dashboard/tabs.js
##########
@@ -190,11 +192,12 @@ export default () =>
// trigger 1 new query
cy.wait('@treemapRequest');
- // no other requests occurred
+ // make sure query API not requested multiple times
cy.on('fail', err => {
- expect(err.message).to.include('Timed out retrying');
+ expect(err.message).to.include('timed out waiting');
Review comment:
The error message changed in Cypress v4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda commented on issue #9490: [Build]
Add Github workflows
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on issue #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#issuecomment-611024478
Looks good - have you thought about Circle?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud closed pull request #9490: [Build] Add
Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud closed pull request #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9490: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#discussion_r406008930
##########
File path: superset-frontend/cypress-base/cypress.json
##########
@@ -1,13 +1,14 @@
{
"baseUrl": "http://localhost:8081",
"chromeWebSecurity": false,
- "defaultCommandTimeout": 20000,
- "requestTimeout": 20000,
- "ignoreTestFiles": ["**/!(*.test.js)"],
- "projectId": "fbf96q",
+ "defaultCommandTimeout": 5000,
Review comment:
No need to actually wait for 20s for default commands (e.g., click triggers).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9490: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#discussion_r406062578
##########
File path: superset-frontend/cypress-base/cypress/integration/dashboard/edit_mode.js
##########
@@ -23,37 +23,22 @@ export default () =>
beforeEach(() => {
cy.server();
cy.login();
-
cy.visit(WORLD_HEALTH_DASHBOARD);
- cy.get('#app').then(data => {
- const bootstrapData = JSON.parse(data[0].dataset.bootstrap);
- const dashboard = bootstrapData.dashboard_data;
- const dashboardId = dashboard.id;
- const boxplotChartId = dashboard.slices.find(
- slice => slice.form_data.viz_type === 'box_plot',
- ).slice_id;
- const formData = `{"slice_id":${boxplotChartId}}`;
- const boxplotRequest = `/superset/explore_json/?form_data=${formData}&dashboard_id=${dashboardId}`;
- cy.route('POST', boxplotRequest).as('boxplotRequest');
- });
-
cy.get('.dashboard-header')
.contains('Edit dashboard')
.click();
});
it('remove, and add chart flow', () => {
- // wait box_plot data and find box plot
- cy.wait('@boxplotRequest');
- cy.get('.grid-container .box_plot').should('be.exist');
+ // wait for box plot to appear
+ cy.get('.grid-container .box_plot');
Review comment:
A simple `get` will wait for the element to appear. No need to wait for the additional request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9490: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#discussion_r406063905
##########
File path: superset-frontend/cypress-base/cypress/integration/dashboard/save.js
##########
@@ -61,11 +60,7 @@ export default () =>
it('should save/overwrite dashboard', () => {
// should have box_plot chart
- const formData = `{"slice_id":${boxplotChartId}}`;
- const boxplotRequest = `/superset/explore_json/?form_data=${formData}&dashboard_id=${dashboardId}`;
- cy.route('POST', boxplotRequest).as('boxplotRequest');
- cy.wait('@boxplotRequest');
- cy.get('.grid-container .box_plot').should('be.exist');
+ cy.get('.grid-container .box_plot', { timeout: 5000 }); // wait for 5 secs
Review comment:
Again, a simple `get` will wait. Also, `dashboardId` may be out of sync when test cases are running in parallelized mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9490: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#discussion_r406008138
##########
File path: .github/workflows/superset-e2e.yml
##########
@@ -0,0 +1,80 @@
+name: E2E
+
+on:
+ push:
+ branches: [ master ]
+ pull_request:
+
+jobs:
+ cypress:
+ name: Cypress
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ python-version: [3.6]
+ env:
+ SUPERSET_CONFIG: tests.superset_test_config
+ PYTHONPATH: ${{ github.workspace }}
+ REDIS_PORT: 16379
+ CI: github-actions
+ CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ services:
+ redis:
+ image: redis:5-alpine
+ ports:
+ - 16379:6379
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Set up Python ${{ matrix.python-version }}
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Cache pip
+ uses: actions/cache@v1
+ with:
+ path: ~/.cache/pip
+ key: ${{ runner.os }}-pip-${{ hashFiles('./requirements*.txt') }}
+ restore-keys: |
+ ${{ runner.os }}-pip-
+ - name: Cache npm
+ uses: actions/cache@v1
+ with:
+ path: |
+ ~/.npm
+ superset-frontend/.terser-plugin-cache/
+ key: ${{ runner.os }}-npm-${{ hashFiles('superset-frontend/package-lock.json') }}
+ restore-keys: |
+ ${{ runner.os }}-npm-
+ - name: Install dependencies
+ uses: ./.github/actions/setup-superset
+ with:
+ prepare: backend frontend testdata
+ - name: Cypress run all
+ uses: cypress-io/github-action@v1
+ with:
+ working-directory: ./superset-frontend/cypress-base
+ # cannot use `superset run` because it starts the app somehow differently
+ # and would not respect the `SUPERSET_CONFIG` env
+ start: flask run -p 8081 --no-debugger
+ wait-on: http://localhost:8081
+ wait-on-timeout: 10
+ spec: cypress/integration/*/*
+ record: true
Review comment:
I'm enabling recording as it's free anyway. Check the recorded logs [here](https://dashboard.cypress.io/projects/dk2opw/).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on issue #9490: [Build] Add
Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#issuecomment-611033992
CircleCI was my first choice, but it seems there are some administration overheads involved in setting it up and no other Apache projects are using it AFAIK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9490:
[Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#issuecomment-611325473
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=h1) Report
> Merging [#9490](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5565895819dff7a126429ae7a696d194aa97c9db&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9490 +/- ##
=======================================
Coverage 58.77% 58.77%
=======================================
Files 385 385
Lines 12239 12239
Branches 3022 3022
=======================================
Hits 7193 7193
Misses 4862 4862
Partials 184 184
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=footer). Last update [5565895...04fd288](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9490: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#discussion_r406008417
##########
File path: superset-frontend/cypress-base/.gitignore
##########
@@ -0,0 +1 @@
+cypress/screenshots/
Review comment:
Local builds may generate this folder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9490:
[Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#issuecomment-611325473
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=h1) Report
> Merging [#9490](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5565895819dff7a126429ae7a696d194aa97c9db&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9490 +/- ##
=======================================
Coverage 58.77% 58.77%
=======================================
Files 385 385
Lines 12239 12239
Branches 3022 3022
=======================================
Hits 7193 7193
Misses 4862 4862
Partials 184 184
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=footer). Last update [5565895...2df178f](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9490: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#discussion_r406010027
##########
File path: superset-frontend/cypress-base/cypress.json
##########
@@ -1,13 +1,14 @@
{
"baseUrl": "http://localhost:8081",
"chromeWebSecurity": false,
- "defaultCommandTimeout": 20000,
- "requestTimeout": 20000,
- "ignoreTestFiles": ["**/!(*.test.js)"],
- "projectId": "fbf96q",
+ "defaultCommandTimeout": 5000,
+ "requestTimeout": 10000,
+ "ignoreTestFiles": [
+ "**/!(*.test.js)"
+ ],
"video": false,
"videoUploadOnPasses": false,
"viewportWidth": 1280,
"viewportHeight": 800,
- "requestTimeout": 10000
+ "projectId": "dk2opw"
Review comment:
Updated to a project under my personal account for testing. Will need to change back to [the official project ](https://dashboard.cypress.io/projects/fbf96q/runs) once merged.
Someone with admin access on GitHub please [add a new record key](https://docs.cypress.io/guides/dashboard/projects.html#Set-up-a-project-to-record) to [GitHub Actions secrets](https://github.com/apache/incubator-superset/settings/secrets) under the name `CYPRESS_RECORD_KEY`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9490: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#discussion_r406005614
##########
File path: .github/workflows/superset-e2e.yml
##########
@@ -0,0 +1,80 @@
+name: E2E
+
+on:
+ push:
+ branches: [ master ]
+ pull_request:
+
+jobs:
+ cypress:
+ name: Cypress
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ python-version: [3.6]
+ env:
+ SUPERSET_CONFIG: tests.superset_test_config
+ PYTHONPATH: ${{ github.workspace }}
+ REDIS_PORT: 16379
+ CI: github-actions
+ CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ services:
+ redis:
+ image: redis:5-alpine
+ ports:
+ - 16379:6379
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Set up Python ${{ matrix.python-version }}
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Cache pip
+ uses: actions/cache@v1
+ with:
+ path: ~/.cache/pip
+ key: ${{ runner.os }}-pip-${{ hashFiles('./requirements*.txt') }}
+ restore-keys: |
+ ${{ runner.os }}-pip-
+ - name: Cache npm
+ uses: actions/cache@v1
+ with:
+ path: |
+ ~/.npm
+ superset-frontend/.terser-plugin-cache/
+ key: ${{ runner.os }}-npm-${{ hashFiles('superset-frontend/package-lock.json') }}
Review comment:
Cypress plugin will handle its own cache. So not need to add `cypress-base/package-lock.json` as hash key.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9490: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#discussion_r406063085
##########
File path: superset-frontend/cypress-base/cypress/integration/dashboard/load.js
##########
@@ -49,12 +49,15 @@ export default () =>
it('should load dashboard', () => {
// wait and verify one-by-one
cy.wait(aliases).then(requests => {
- requests.forEach(async xhr => {
- expect(xhr.status).to.eq(200);
- const responseBody = await readResponseBlob(xhr.response.body);
- expect(responseBody).to.have.property('error', null);
- cy.get(`#slice-container-${xhr.response.body.form_data.slice_id}`);
- });
+ return Promise.all(
+ requests.map(async xhr => {
+ expect(xhr.status).to.eq(200);
+ const responseBody = await readResponseBlob(xhr.response.body);
+ expect(responseBody).to.have.property('error', null);
+ const sliceId = responseBody.form_data.slice_id;
+ cy.get(`#chart-id-${sliceId}`).should('be.visible');
Review comment:
Has to return a `Promise` for the test cases to be captured.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9490:
[Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#issuecomment-611325473
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=h1) Report
> Merging [#9490](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5565895819dff7a126429ae7a696d194aa97c9db&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9490 +/- ##
=======================================
Coverage 58.77% 58.77%
=======================================
Files 385 385
Lines 12239 12239
Branches 3022 3022
=======================================
Hits 7193 7193
Misses 4862 4862
Partials 184 184
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=footer). Last update [5565895...282b39e](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9490: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#discussion_r406008676
##########
File path: superset-frontend/cypress-base/cypress.json
##########
@@ -1,13 +1,14 @@
{
"baseUrl": "http://localhost:8081",
"chromeWebSecurity": false,
- "defaultCommandTimeout": 20000,
- "requestTimeout": 20000,
- "ignoreTestFiles": ["**/!(*.test.js)"],
- "projectId": "fbf96q",
+ "defaultCommandTimeout": 5000,
+ "requestTimeout": 10000,
+ "ignoreTestFiles": [
+ "**/!(*.test.js)"
+ ],
"video": false,
"videoUploadOnPasses": false,
"viewportWidth": 1280,
"viewportHeight": 800,
- "requestTimeout": 10000
Review comment:
The original config has duplicate `requestTimeout`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9490: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#discussion_r406008930
##########
File path: superset-frontend/cypress-base/cypress.json
##########
@@ -1,13 +1,14 @@
{
"baseUrl": "http://localhost:8081",
"chromeWebSecurity": false,
- "defaultCommandTimeout": 20000,
- "requestTimeout": 20000,
- "ignoreTestFiles": ["**/!(*.test.js)"],
- "projectId": "fbf96q",
+ "defaultCommandTimeout": 5000,
Review comment:
No need to actually wait for 20s for default commands (e.g., click triggers).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9490: [Build]
Add Github workflows
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#issuecomment-611325473
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=h1) Report
> Merging [#9490](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5565895819dff7a126429ae7a696d194aa97c9db&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9490 +/- ##
=======================================
Coverage 58.77% 58.77%
=======================================
Files 385 385
Lines 12239 12239
Branches 3022 3022
=======================================
Hits 7193 7193
Misses 4862 4862
Partials 184 184
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=footer). Last update [5565895...9ab2846](https://codecov.io/gh/apache/incubator-superset/pull/9490?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9490: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#discussion_r406502040
##########
File path: superset-frontend/cypress-base/cypress/integration/explore/visualizations/big_number.js
##########
@@ -56,8 +56,8 @@ export default () =>
it('should work', () => {
verify(BIG_NUMBER_FORM_DATA);
- cy.get('.chart-container .header_line');
- cy.get('.chart-container .subheader_line');
+ cy.get('.chart-container .header-line');
+ cy.get('.chart-container .subheader-line');
Review comment:
`explore/visualizations/index.test.js` was probably unintentioally disabled by https://github.com/apache/incubator-superset/pull/6241 .
It has since stopped running for over a year now. A lot of these tests are now broken. It's easy to add them back, but we may want to do the fix in another PR. Keep the changes for BigNumber here just for reference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9490: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9490: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9490#discussion_r406010027
##########
File path: superset-frontend/cypress-base/cypress.json
##########
@@ -1,13 +1,14 @@
{
"baseUrl": "http://localhost:8081",
"chromeWebSecurity": false,
- "defaultCommandTimeout": 20000,
- "requestTimeout": 20000,
- "ignoreTestFiles": ["**/!(*.test.js)"],
- "projectId": "fbf96q",
+ "defaultCommandTimeout": 5000,
+ "requestTimeout": 10000,
+ "ignoreTestFiles": [
+ "**/!(*.test.js)"
+ ],
"video": false,
"videoUploadOnPasses": false,
"viewportWidth": 1280,
"viewportHeight": 800,
- "requestTimeout": 10000
+ "projectId": "dk2opw"
Review comment:
Updated to a project under my personal account for testing. Will need to change back to [the official project ](https://dashboard.cypress.io/projects/fbf96q/runs) once merged.
Someone with admin access on GitHub please [add a new record key](https://docs.cypress.io/guides/dashboard/projects.html#Set-up-a-project-to-record) to [GitHub Actions secrets](https://help.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets) under the name `CYPRESS_RECORD_KEY`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org