You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2018/09/24 15:30:04 UTC
[jira] [Commented] (PHOENIX-4854) Make LoggingPhoenixResultSet
idempotent when logging metrics
[ https://issues.apache.org/jira/browse/PHOENIX-4854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626010#comment-16626010 ]
Hudson commented on PHOENIX-4854:
---------------------------------
FAILURE: Integrated in Jenkins build Phoenix-omid2 #89 (See [https://builds.apache.org/job/Phoenix-omid2/89/])
PHOENIX-4854 Make LoggingPhoenixResultSet idempotent when logging (karanmehta93: rev 7a2edb871884d38a4f3dd4472bb5b2ca139bf0f1)
* (edit) phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixLoggingMetricsIT.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/jdbc/LoggingPhoenixResultSet.java
> Make LoggingPhoenixResultSet idempotent when logging metrics
> ------------------------------------------------------------
>
> Key: PHOENIX-4854
> URL: https://issues.apache.org/jira/browse/PHOENIX-4854
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Karan Mehta
> Assignee: Karan Mehta
> Priority: Major
> Fix For: 4.15.0, 5.1.0
>
>
> ResultSet close method can be called multiple times and LoggingResultSet object tries to call PhoenixMetricsLog methods every single time. These per query metrics don't get cleared up, rather they are all at "0" value once they are consumed and reset. This Jira is an enhancement to bring the idempotency in the class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)