[GitHub] anthonyvdotbe commented on a change in pull request #1036: [NETBEANS-1733] Ask when downloading nbjavac - backport to 10.0 release

[GitBox <gi...@apache.org>]

anthonyvdotbe commented on a change in pull request #1036: [NETBEANS-1733] Ask when downloading nbjavac - backport to 10.0 release
URL: https://github.com/apache/incubator-netbeans/pull/1036#discussion_r236048622
 
 

 ##########
 File path: ergonomics/ide.ergonomics/src/org/netbeans/modules/ide/ergonomics/fod/ModulesInstaller.java
 ##########
 @@ -207,32 +204,19 @@ private void doInstallMissingModules () throws OperationException {
         if (! installContainer.listInvalid ().isEmpty ()) {
             throw new IllegalArgumentException ("Some are invalid for install: " + installContainer.listInvalid ());
         }
-        InstallSupport installSupport = installContainer.getSupport ();
-        if (downloadHandle == null) {
-            downloadHandle = ProgressHandleFactory.createHandle (
-                getBundle ("InstallerMissingModules_Download",
-                presentUpdateElements (finder.getVisibleUpdateElements (modules4install))));
-        }
-        progressMonitor.onDownload(downloadHandle);
-        Validator v = installSupport.doDownload (downloadHandle, false);
-        if (verifyHandle == null) {
-            verifyHandle = ProgressHandleFactory.createHandle (
-                    getBundle ("InstallerMissingModules_Verify"));
-            }
-        progressMonitor.onValidate(verifyHandle);
-        Installer i = installSupport.doValidate (v, verifyHandle);
-        if (installHandle == null) {
-            installHandle = ProgressHandleFactory.createHandle (
-                    getBundle ("InstallerMissingModules_Install"));
+        boolean ok = PluginManager.openInstallWizard(installContainer);
+        if (!ok) {
+            StringBuilder sb = new StringBuilder();
 
 Review comment:
   For what it's worth, you might want to use a Stream instead (with a static import for `Collectors::joining`):
   
   ```suggestion
               String s = modules4install.stream()
                   .map(UpdateElement::getDisplayName)
                   .collect(joining(", "));
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists