[jira] [Commented] (TEZ-2937) Can Processor.close() be called after closing inputs and outputs?

["Bikas Saha (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15099175#comment-15099175 ] 

Bikas Saha commented on TEZ-2937:
---------------------------------

lgtm. 

Unrelated to the patch, but maybe the llap version of LIORuntimeTask may need the same change in Hive. //cc [~sseth] [~rajesh.balamohan]

> Can Processor.close() be called after closing inputs and outputs?
> -----------------------------------------------------------------
>
>                 Key: TEZ-2937
>                 URL: https://issues.apache.org/jira/browse/TEZ-2937
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Rohini Palaniswamy
>         Attachments: TEZ-2937.1.patch
>
>
> Pig hit PIG-4722 as processor.close() which clears some static thread local variables was called when SpillThread was still running the Combiner.  LogicalIOProcessorRuntimeTask.java calls processor.close() before closing the inputs and outputs in both close() and cleanup() methods. Can Tez change to closing the processor after the inputs and outputs are closed? 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)