[GitHub] jglick commented on a change in pull request #1063: Updating to Felix 6.0.1

[GitBox <gi...@apache.org>]

jglick commented on a change in pull request #1063: Updating to Felix 6.0.1
URL: https://github.com/apache/incubator-netbeans/pull/1063#discussion_r244613026
 
 

 ##########
 File path: platform/core.osgi/src/org/netbeans/core/osgi/OSGiRepository.java
 ##########
 @@ -119,8 +118,17 @@ public void removeLayersFor(List<Bundle> bundles) {
     private static final class SFS extends MultiFileSystem implements LookupListener {
 
         static {
-            @SuppressWarnings("deprecation") Object _1 = FileSystem$Environment.class; // FELIX-2128
 
 Review comment:
   [FELIX-2128](https://jira.apache.org/jira/browse/FELIX-2128) nine years ago! AFAICT the intent here was to load some classes which we expected to be loaded anyway. If `FileSystem$Environment` and `FileSystemCapability` have been removed from the active codebase then I presume these two class loads could simply be deleted.
   
   [FELIX-3477](https://jira.apache.org/jira/browse/FELIX-3477) BTW for the `LookupEvent` load, apparently. I do not really remember anything about these issues.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists