You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/02/24 09:17:27 UTC
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2499: Fixes for Coverity issues
apache-mynewt-bot commented on pull request #2499:
URL: https://github.com/apache/mynewt-core/pull/2499#issuecomment-784930773
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/drivers/sensors/bma253/src/bma253.c
<details>
```diff
@@ -5011,8 +5001,8 @@
goto done;
}
- int_enable.s_tap_int_enable = tap_type == BMA253_TAP_TYPE_SINGLE;
- int_enable.d_tap_int_enable = tap_type == BMA253_TAP_TYPE_DOUBLE;
+ int_enable.s_tap_int_enable = tap_type == BMA253_TAP_TYPE_SINGLE;
+ int_enable.d_tap_int_enable = tap_type == BMA253_TAP_TYPE_DOUBLE;
rc = bma253_set_int_enable(bma253, &int_enable);
if (rc != 0) {
```
</details>
#### hw/drivers/sensors/bme680/src/bme680.c
<details>
```diff
@@ -1685,7 +1687,7 @@
hal_gpio_write(interface->si_cs_pin, 0);
(void)hal_spi_tx_val(interface->si_num, reg_addr | 0x80);
/* Use reg_data for the txbuf as well.
- The contents don't matter since we're reading */
+ The contents don't matter since we're reading */
hal_spi_txrx(interface->si_num, reg_data, reg_data, len);
hal_gpio_write(interface->si_cs_pin, 1);
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org