You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/04/30 02:09:14 UTC
[GitHub] [thrift] pacejackson opened a new pull request #2126: THRIFT-5164: Add middleware framework for Go clients
pacejackson opened a new pull request #2126:
URL: https://github.com/apache/thrift/pull/2126
<!-- Explain the changes in the pull request below: -->
This commit adds a simple middleware framework for Go clients.
It provides:
* A `ClientMiddleware` function interface used to define the actual middleware
* `WrapClient`, the function that you use to wrap a `TClient` in a list of middleware
* A helper `WrappedTClient` struct to help with developing middleware
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, add ` [skip ci]` at the end of your pull request to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] pacejackson commented on pull request #2126: THRIFT-5164: Add middleware framework for Go clients
Posted by GitBox <gi...@apache.org>.
pacejackson commented on pull request #2126:
URL: https://github.com/apache/thrift/pull/2126#issuecomment-621572500
@dcelasun Here's the Client middleware part of [THRIFT-5164](https://issues.apache.org/jira/browse/THRIFT-5164)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] dcelasun commented on pull request #2126: THRIFT-5164: Add middleware framework for Go clients
Posted by GitBox <gi...@apache.org>.
dcelasun commented on pull request #2126:
URL: https://github.com/apache/thrift/pull/2126#issuecomment-621878642
LGTM, thanks for the PR!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org