You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/11/27 01:25:06 UTC

[GitHub] [commons-vfs] garydgregory commented on pull request #168: [VFS-798] IllegalArgumentException: Bad escape for Chinese characters in FileObject path

garydgregory commented on pull request #168:
URL: https://github.com/apache/commons-vfs/pull/168#issuecomment-980481711


   Hi All. 
   This PR is _not_ ready yet because the tests pass when no change to `main` are applied. 
   The new tests _must_ fail in this case, otherwise they do not prove that the changes to `main` fix or change anything. 
   IOW, using TDD here: Write the tests FIRST, see them fail, fix the bug in main, run the test again, if they now pass, all is well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org