Re: Code Convention: Eclipse formatter

[Jeff Zhang <zj...@gmail.com>]

I use intellij which can specify the checkstyle file for project. I think
eclipse should able be able to do that.

https://github.com/apache/zeppelin/blob/master/_tools/checkstyle.xml



Gokulakannan Muralidharan <go...@sentienz.com>于2018年2月28日周三 下午1:45写道：

> Hi,
>
> Google code style format
> <https://github.com/google/styleguide/blob/gh-pages/eclipse-java-google-style.xml> for
> Java is not working for Zeppelin project as mentioned in the docs
> <https://zeppelin.apache.org/contribution/contributions.html#code-convention>,
> getting checkstyle errors when trying to build locally.
>
> Could someone please share the eclipse code formatter used for Zeppelin
> java code?
>
> Regards,
> Gokul
>
>

Re: Code Convention: Eclipse formatter

[Jongyoul Lee <jo...@gmail.com>]

Hi,

Those formatters are not fully compatible. So Incompatibility always
happens. I think fixing format through checkstyle would be better.

Thanks,
JL

On Thu, Mar 1, 2018 at 2:07 PM, Gokulakannan Muralidharan <
gokul@sentienz.com> wrote:

> Thanks Jeff, tried importing it in eclipse it is not working.
>
> Looks like eclipse code formatter can be imported in intellij using *eclipse
> formatter plugin* for intellij and not vice versa
> https://intellij-support.jetbrains.com/hc/en-us/
> community/posts/206575559-How-to-Export-Code-Formatting-
> Configurations-to-Eclipse
>
> On Thu, Mar 1, 2018 at 8:09 AM, Jeff Zhang <zj...@gmail.com> wrote:
>
>>
>> I use intellij which can specify the checkstyle file for project. I think
>> eclipse should able be able to do that.
>>
>> https://github.com/apache/zeppelin/blob/master/_tools/checkstyle.xml
>>
>>
>>
>> Gokulakannan Muralidharan <go...@sentienz.com>于2018年2月28日周三 下午1:45写道：
>>
>>> Hi,
>>>
>>> Google code style format
>>> <https://github.com/google/styleguide/blob/gh-pages/eclipse-java-google-style.xml> for
>>> Java is not working for Zeppelin project as mentioned in the docs
>>> <https://zeppelin.apache.org/contribution/contributions.html#code-convention>,
>>> getting checkstyle errors when trying to build locally.
>>>
>>> Could someone please share the eclipse code formatter used for Zeppelin
>>> java code?
>>>
>>> Regards,
>>> Gokul
>>>
>>>
>


-- 
이종열, Jongyoul Lee, 李宗烈
http://madeng.net

Re: Code Convention: Eclipse formatter

[Gokulakannan Muralidharan <go...@sentienz.com>]

Thanks Jeff, tried importing it in eclipse it is not working.

Looks like eclipse code formatter can be imported in intellij using *eclipse
formatter plugin* for intellij and not vice versa
https://intellij-support.jetbrains.com/hc/en-us/community/posts/206575559-How-to-Export-Code-Formatting-Configurations-to-Eclipse

On Thu, Mar 1, 2018 at 8:09 AM, Jeff Zhang <zj...@gmail.com> wrote:

>
> I use intellij which can specify the checkstyle file for project. I think
> eclipse should able be able to do that.
>
> https://github.com/apache/zeppelin/blob/master/_tools/checkstyle.xml
>
>
>
> Gokulakannan Muralidharan <go...@sentienz.com>于2018年2月28日周三 下午1:45写道：
>
>> Hi,
>>
>> Google code style format
>> <https://github.com/google/styleguide/blob/gh-pages/eclipse-java-google-style.xml> for
>> Java is not working for Zeppelin project as mentioned in the docs
>> <https://zeppelin.apache.org/contribution/contributions.html#code-convention>,
>> getting checkstyle errors when trying to build locally.
>>
>> Could someone please share the eclipse code formatter used for Zeppelin
>> java code?
>>
>> Regards,
>> Gokul
>>
>>