[GitHub] [lucene] mocobeta commented on a change in pull request #744: LUCENE-10459: add demo dependencies to third party modules. Add an IT…

[GitBox <gi...@apache.org>]

mocobeta commented on a change in pull request #744:
URL: https://github.com/apache/lucene/pull/744#discussion_r824587863



##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -657,8 +657,8 @@ def testDemo(run_java, isSrc, version, jdk):
     indexFilesCmd = 'java -cp "%s" -Dsmoketester=true org.apache.lucene.demo.IndexFiles -index index -docs %s' % (cp, docsDir)
     searchFilesCmd = 'java -cp "%s" org.apache.lucene.demo.SearchFiles -index index -query lucene' % cp
   else:
-    # For binary release, set up classpath as modules.
-    cp = "--module-path modules"
+    # For binary release, set up module path.
+    cp = "--module-path %s" % (sep.join("modules", "modules-thirdparty"))

Review comment:
       `join()` takes a list;  `[` and `]` is needed.
   ```suggestion
       cp = "--module-path %s" % (sep.join(["modules", "modules-thirdparty"]))
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org