You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/09 12:36:28 UTC
[GitHub] [flink] wangxlong opened a new pull request #10814:
[FLINK-15434][Tests]Fix unstable tests in JobMasterTest
wangxlong opened a new pull request #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814
## What is the purpose of the change
Fix unstable tests in JobMasterTest
## Brief change log
Create the jobmaster with heartbeatServices instead of fastHeartbeatServices for some tests.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10814:
[FLINK-15434][Tests]Fix unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#issuecomment-572552628
<!--
Meta data
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
-->
## CI report:
* a814428b99636921abf55ab089e664cec9d13876 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143727769) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10814:
[FLINK-15434][Tests]Fix unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#issuecomment-572552628
<!--
Meta data
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:MANUAL TriggerID:572839646
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:MANUAL TriggerID:572839646
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:MANUAL TriggerID:572918665
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:MANUAL TriggerID:572918665
Hash:96a81a9b98ba96eb075c9b5f32fd15a6e08082ab Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4311 TriggerType:PUSH TriggerID:96a81a9b98ba96eb075c9b5f32fd15a6e08082ab
Hash:96a81a9b98ba96eb075c9b5f32fd15a6e08082ab Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144255567 TriggerType:PUSH TriggerID:96a81a9b98ba96eb075c9b5f32fd15a6e08082ab
-->
## CI report:
* a814428b99636921abf55ab089e664cec9d13876 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143727769) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228)
* 96a81a9b98ba96eb075c9b5f32fd15a6e08082ab Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144255567) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4311)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10814:
[FLINK-15434][Tests]Fix unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#issuecomment-572552628
<!--
Meta data
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:MANUAL TriggerID:572839646
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:MANUAL TriggerID:572839646
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:MANUAL TriggerID:572918665
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:MANUAL TriggerID:572918665
-->
## CI report:
* a814428b99636921abf55ab089e664cec9d13876 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143727769) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10814: [FLINK-15434][Tests]Fix
unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#issuecomment-572552628
<!--
Meta data
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
-->
## CI report:
* a814428b99636921abf55ab089e664cec9d13876 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10814:
[FLINK-15434][Tests]Fix unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#issuecomment-572552628
<!--
Meta data
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:MANUAL TriggerID:572839646
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:MANUAL TriggerID:572839646
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:MANUAL TriggerID:572918665
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:MANUAL TriggerID:572918665
-->
## CI report:
* a814428b99636921abf55ab089e664cec9d13876 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143727769) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10814:
[FLINK-15434][Tests]Fix unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#issuecomment-572552628
<!--
Meta data
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:MANUAL TriggerID:572839646
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:MANUAL TriggerID:572839646
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:MANUAL TriggerID:572918665
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:MANUAL TriggerID:572918665
Hash:96a81a9b98ba96eb075c9b5f32fd15a6e08082ab Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:96a81a9b98ba96eb075c9b5f32fd15a6e08082ab
-->
## CI report:
* a814428b99636921abf55ab089e664cec9d13876 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143727769) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228)
* 96a81a9b98ba96eb075c9b5f32fd15a6e08082ab UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10814:
[FLINK-15434][Tests]Fix unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#issuecomment-572552628
<!--
Meta data
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:MANUAL TriggerID:572839646
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:MANUAL TriggerID:572839646
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:MANUAL TriggerID:572918665
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:MANUAL TriggerID:572918665
Hash:96a81a9b98ba96eb075c9b5f32fd15a6e08082ab Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4311 TriggerType:PUSH TriggerID:96a81a9b98ba96eb075c9b5f32fd15a6e08082ab
Hash:96a81a9b98ba96eb075c9b5f32fd15a6e08082ab Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144255567 TriggerType:PUSH TriggerID:96a81a9b98ba96eb075c9b5f32fd15a6e08082ab
-->
## CI report:
* a814428b99636921abf55ab089e664cec9d13876 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143727769) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228)
* 96a81a9b98ba96eb075c9b5f32fd15a6e08082ab Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144255567) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4311)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10814:
[FLINK-15434][Tests]Fix unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#issuecomment-572552628
<!--
Meta data
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:MANUAL TriggerID:572839646
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:MANUAL TriggerID:572839646
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:MANUAL TriggerID:572918665
-->
## CI report:
* a814428b99636921abf55ab089e664cec9d13876 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143727769) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on a change in pull request #10814:
[FLINK-15434][Tests]Fix unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#discussion_r365847555
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterTest.java
##########
@@ -708,7 +708,8 @@ public void testRestoringFromSavepoint() throws Exception {
configuration,
jobGraph,
haServices,
- new TestingJobManagerSharedServicesBuilder().build());
+ new TestingJobManagerSharedServicesBuilder().build(),
+ heartbeatServices);
Review comment:
I think strictly speaking the heartbeat timeout doesn't matter here because we are not starting the JobMaster (only invoking the constructor).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangxlong commented on issue #10814:
[FLINK-15434][Tests]Fix unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
wangxlong commented on issue #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#issuecomment-572918665
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on a change in pull request #10814:
[FLINK-15434][Tests]Fix unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#discussion_r365855118
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterTest.java
##########
@@ -820,7 +822,8 @@ public void testCheckpointPrecedesSavepointRecovery() throws Exception {
configuration,
jobGraph,
haServices,
- new TestingJobManagerSharedServicesBuilder().build());
+ new TestingJobManagerSharedServicesBuilder().build(),
+ heartbeatServices);
Review comment:
Same here (only invoking the constructor)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on a change in pull request #10814:
[FLINK-15434][Tests]Fix unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#discussion_r365849192
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterTest.java
##########
@@ -769,7 +770,8 @@ public void testRestoringModifiedJobFromSavepoint() throws Exception {
configuration,
jobGraphWithNewOperator,
haServices,
- new TestingJobManagerSharedServicesBuilder().build());
+ new TestingJobManagerSharedServicesBuilder().build(),
+ heartbeatServices);
Review comment:
Same here (only invoking the constructor)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10814:
[FLINK-15434][Tests]Fix unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#issuecomment-572552628
<!--
Meta data
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:MANUAL TriggerID:572839646
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:MANUAL TriggerID:572839646
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:MANUAL TriggerID:572918665
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:MANUAL TriggerID:572918665
Hash:96a81a9b98ba96eb075c9b5f32fd15a6e08082ab Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4311 TriggerType:PUSH TriggerID:96a81a9b98ba96eb075c9b5f32fd15a6e08082ab
Hash:96a81a9b98ba96eb075c9b5f32fd15a6e08082ab Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144255567 TriggerType:PUSH TriggerID:96a81a9b98ba96eb075c9b5f32fd15a6e08082ab
-->
## CI report:
* a814428b99636921abf55ab089e664cec9d13876 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143727769) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228)
* 96a81a9b98ba96eb075c9b5f32fd15a6e08082ab Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144255567) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4311)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10814:
[FLINK-15434][Tests]Fix unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#issuecomment-572552628
<!--
Meta data
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:MANUAL TriggerID:572839646
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:MANUAL TriggerID:572839646
-->
## CI report:
* a814428b99636921abf55ab089e664cec9d13876 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143727769) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10814: [FLINK-15434][Tests]Fix
unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#issuecomment-572544506
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a814428b99636921abf55ab089e664cec9d13876 (Thu Jan 09 12:41:25 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10814:
[FLINK-15434][Tests]Fix unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#issuecomment-572552628
<!--
Meta data
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
-->
## CI report:
* a814428b99636921abf55ab089e664cec9d13876 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143727769) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangxlong commented on issue #10814:
[FLINK-15434][Tests]Fix unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
wangxlong commented on issue #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#issuecomment-572839646
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on issue #10814: [FLINK-15434][Tests]Fix
unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
GJL commented on issue #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#issuecomment-573109310
Sorry, didn't have time to look at your PR yet but I will in the next days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangxlong commented on issue #10814:
[FLINK-15434][Tests]Fix unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
wangxlong commented on issue #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#issuecomment-573966566
Thank you @GJL. You are right, the other three tests only invoke the constructor, and no need to modify.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10814:
[FLINK-15434][Tests]Fix unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#issuecomment-572552628
<!--
Meta data
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:MANUAL TriggerID:572839646
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:MANUAL TriggerID:572839646
-->
## CI report:
* a814428b99636921abf55ab089e664cec9d13876 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143727769) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on issue #10814: [FLINK-15434][Tests]Fix
unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
GJL commented on issue #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#issuecomment-574563947
Merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10814:
[FLINK-15434][Tests]Fix unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#issuecomment-572552628
<!--
Meta data
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:MANUAL TriggerID:572839646
-->
## CI report:
* a814428b99636921abf55ab089e664cec9d13876 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143727769) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL closed pull request #10814: [FLINK-15434][Tests]Fix
unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
GJL closed pull request #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangxlong commented on issue #10814:
[FLINK-15434][Tests]Fix unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
wangxlong commented on issue #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#issuecomment-572918616
It is failed in python molule. I run travis again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10814:
[FLINK-15434][Tests]Fix unstable tests in JobMasterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#issuecomment-572552628
<!--
Meta data
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143727769 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
Hash:a814428b99636921abf55ab089e664cec9d13876 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228 TriggerType:PUSH TriggerID:a814428b99636921abf55ab089e664cec9d13876
-->
## CI report:
* a814428b99636921abf55ab089e664cec9d13876 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143727769) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4228)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services