You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by as...@apache.org on 2019/07/19 19:30:29 UTC

[qpid-proton] 03/04: PROTON-2062: [Ruby] Sender auto settlement should only happen after receiver settlement

This is an automated email from the ASF dual-hosted git repository.

astitcher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/qpid-proton.git

commit f0ead4862afd5bfb29bf1dbe914acd17de81287a
Author: Andrew Stitcher <as...@apache.org>
AuthorDate: Fri Jul 19 14:25:03 2019 -0400

    PROTON-2062: [Ruby] Sender auto settlement should only happen after receiver settlement
---
 ruby/lib/handler/messaging_adapter.rb | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/ruby/lib/handler/messaging_adapter.rb b/ruby/lib/handler/messaging_adapter.rb
index ab7234b..acc25c0 100644
--- a/ruby/lib/handler/messaging_adapter.rb
+++ b/ruby/lib/handler/messaging_adapter.rb
@@ -124,8 +124,10 @@ module Qpid::Proton
           when Delivery::RELEASED then delegate(:on_tracker_release, t)
           when Delivery::MODIFIED then delegate(:on_tracker_modify, t)
           end
-          delegate(:on_tracker_settle, t) if t.settled?
-          t.settle if t.sender.auto_settle
+          if t.settled?
+            delegate(:on_tracker_settle, t)
+            t.settle if t.sender.auto_settle
+          end
         end
       end
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org