You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/08 15:37:06 UTC
[GitHub] [pulsar] nicoloboschi opened a new pull request, #17551: [ci] Skip run flaky tests suite for cpp-only or doc-only changes
nicoloboschi opened a new pull request, #17551:
URL: https://github.com/apache/pulsar/pull/17551
### Motivation
The new flaky suite workflow can be skipped in case of doc-only or cpp-only changes.
### Modifications
* Used `paths-ignore` copying paths from the changes-filter.yaml file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #17551: [ci] Skip run flaky tests suite for cpp-only or doc-only changes
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on code in PR #17551:
URL: https://github.com/apache/pulsar/pull/17551#discussion_r966151871
##########
.github/workflows/pulsar-ci-flaky.yaml:
##########
@@ -22,9 +22,27 @@ on:
pull_request:
branches:
- master
+ paths-ignore:
+ # Doc
+ - 'site2/**'
+ - 'deployment/**'
+ - '.asf.yaml'
+ - '*.md'
+ - '**/*.md'
+ # CPP
+ - 'pulsar-client-cpp/**'
push:
branches:
- branch-*
+ paths-ignore:
+ # Doc
+ - 'site2/**'
+ - 'deployment/**'
+ - '.asf.yaml'
+ - '*.md'
+ - '**/*.md'
+ # CPP
+ - 'pulsar-client-cpp/**'
Review Comment:
the [doc](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions) says
>When all the path names match patterns in paths-ignore, the workflow will not run. If any path names do not match patterns in paths-ignore, even if some path names match the patterns, the workflow will run.
what kind of risks you think we run ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a diff in pull request #17551: [ci] Skip run flaky tests suite for cpp-only or doc-only changes
Posted by GitBox <gi...@apache.org>.
lhotari commented on code in PR #17551:
URL: https://github.com/apache/pulsar/pull/17551#discussion_r966150246
##########
.github/workflows/pulsar-ci-flaky.yaml:
##########
@@ -22,9 +22,27 @@ on:
pull_request:
branches:
- master
+ paths-ignore:
+ # Doc
+ - 'site2/**'
+ - 'deployment/**'
+ - '.asf.yaml'
+ - '*.md'
+ - '**/*.md'
+ # CPP
+ - 'pulsar-client-cpp/**'
push:
branches:
- branch-*
+ paths-ignore:
+ # Doc
+ - 'site2/**'
+ - 'deployment/**'
+ - '.asf.yaml'
+ - '*.md'
+ - '**/*.md'
+ # CPP
+ - 'pulsar-client-cpp/**'
Review Comment:
I'd recommend keeping the changed_files_job based solution since there's a risk that we run into problems with this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17551: [ci] Skip run flaky tests suite for cpp-only or doc-only changes
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17551:
URL: https://github.com/apache/pulsar/pull/17551#discussion_r966158500
##########
.github/workflows/pulsar-ci-flaky.yaml:
##########
@@ -22,9 +22,27 @@ on:
pull_request:
branches:
- master
+ paths-ignore:
+ # Doc
+ - 'site2/**'
+ - 'deployment/**'
+ - '.asf.yaml'
+ - '*.md'
+ - '**/*.md'
+ # CPP
+ - 'pulsar-client-cpp/**'
push:
branches:
- branch-*
+ paths-ignore:
+ # Doc
+ - 'site2/**'
+ - 'deployment/**'
+ - '.asf.yaml'
+ - '*.md'
+ - '**/*.md'
+ # CPP
+ - 'pulsar-client-cpp/**'
Review Comment:
For me, [paths-filter](https://github.com/apache/pulsar-test-infra/tree/master/paths-filter) is there because currently GitHub doesn't support `paths` and `paths-ignore` at job level or step level. So it should be effectively the same as those two filters.
I don't object to use a `changed_files_job`. Thanks for your effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #17551: [ci] Skip run flaky tests suite for cpp-only or doc-only changes
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on code in PR #17551:
URL: https://github.com/apache/pulsar/pull/17551#discussion_r966156426
##########
.github/workflows/pulsar-ci-flaky.yaml:
##########
@@ -22,9 +22,27 @@ on:
pull_request:
branches:
- master
+ paths-ignore:
+ # Doc
+ - 'site2/**'
+ - 'deployment/**'
+ - '.asf.yaml'
+ - '*.md'
+ - '**/*.md'
+ # CPP
+ - 'pulsar-client-cpp/**'
push:
branches:
- branch-*
+ paths-ignore:
+ # Doc
+ - 'site2/**'
+ - 'deployment/**'
+ - '.asf.yaml'
+ - '*.md'
+ - '**/*.md'
+ # CPP
+ - 'pulsar-client-cpp/**'
Review Comment:
@tisonkun flaky tests suite contains only java tests.
btw @lhotari I moved back to the changed_files check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #17551: [ci] Skip run flaky tests suite for cpp-only or doc-only changes
Posted by GitBox <gi...@apache.org>.
lhotari merged PR #17551:
URL: https://github.com/apache/pulsar/pull/17551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a diff in pull request #17551: [ci] Skip run flaky tests suite for cpp-only or doc-only changes
Posted by GitBox <gi...@apache.org>.
lhotari commented on code in PR #17551:
URL: https://github.com/apache/pulsar/pull/17551#discussion_r966149621
##########
.github/workflows/pulsar-ci-flaky.yaml:
##########
@@ -22,9 +22,27 @@ on:
pull_request:
branches:
- master
+ paths-ignore:
+ # Doc
+ - 'site2/**'
+ - 'deployment/**'
+ - '.asf.yaml'
+ - '*.md'
+ - '**/*.md'
+ # CPP
+ - 'pulsar-client-cpp/**'
push:
branches:
- branch-*
+ paths-ignore:
+ # Doc
+ - 'site2/**'
+ - 'deployment/**'
+ - '.asf.yaml'
+ - '*.md'
+ - '**/*.md'
+ # CPP
+ - 'pulsar-client-cpp/**'
Review Comment:
there might be some consequences in this change because paths-ignore works in a certain way. I'm not exactly sure if this would be a good thing to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17551: [ci] Skip run flaky tests suite for cpp-only or doc-only changes
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17551:
URL: https://github.com/apache/pulsar/pull/17551#discussion_r966158500
##########
.github/workflows/pulsar-ci-flaky.yaml:
##########
@@ -22,9 +22,27 @@ on:
pull_request:
branches:
- master
+ paths-ignore:
+ # Doc
+ - 'site2/**'
+ - 'deployment/**'
+ - '.asf.yaml'
+ - '*.md'
+ - '**/*.md'
+ # CPP
+ - 'pulsar-client-cpp/**'
push:
branches:
- branch-*
+ paths-ignore:
+ # Doc
+ - 'site2/**'
+ - 'deployment/**'
+ - '.asf.yaml'
+ - '*.md'
+ - '**/*.md'
+ # CPP
+ - 'pulsar-client-cpp/**'
Review Comment:
For me, [paths-filter](https://github.com/apache/pulsar-test-infra/tree/master/paths-filter) is there because currently GitHub doesn't support `paths` and `paths-ignore` in job level or step level. So it should be effectively the same as those two filters.
I don't object to use a `changed_files_job`. Thanks for your effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #17551: [ci] Skip run flaky tests suite for cpp-only or doc-only changes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17551:
URL: https://github.com/apache/pulsar/pull/17551#issuecomment-1241867690
@nicoloboschi Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17551: [ci] Skip run flaky tests suite for cpp-only or doc-only changes
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17551:
URL: https://github.com/apache/pulsar/pull/17551#discussion_r966155608
##########
.github/workflows/pulsar-ci-flaky.yaml:
##########
@@ -22,9 +22,27 @@ on:
pull_request:
branches:
- master
+ paths-ignore:
+ # Doc
+ - 'site2/**'
+ - 'deployment/**'
+ - '.asf.yaml'
+ - '*.md'
+ - '**/*.md'
+ # CPP
+ - 'pulsar-client-cpp/**'
push:
branches:
- branch-*
+ paths-ignore:
+ # Doc
+ - 'site2/**'
+ - 'deployment/**'
+ - '.asf.yaml'
+ - '*.md'
+ - '**/*.md'
+ # CPP
+ - 'pulsar-client-cpp/**'
Review Comment:
As long as all flaky tests are not cpp/py tests, this changes should be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org