You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Mark Webb (JIRA)" <ji...@apache.org> on 2006/10/31 04:24:16 UTC
[jira] Created: (DIRMINA-299) innacurate JMX statistics
innacurate JMX statistics
-------------------------
Key: DIRMINA-299
URL: http://issues.apache.org/jira/browse/DIRMINA-299
Project: Directory MINA
Issue Type: Bug
Components: Core
Affects Versions: 1.1
Environment: Fedora Core 5, Eclipse 3.2 using Java 1.4 compiler settings.
Reporter: Mark Webb
Priority: Minor
The class org.apache.mina.integration.jmx.IoServiceManager computes the bytes read/written using the service's managed sessions using the method IoService.getManagedSessions(). This method returns a java.util.Set object, which only contains the sessions currently active.
The IoServiceManager class uses org.apache.mina.management.StatCollector class to assist with tracking data throughput. The StatCollector class only operates on active sessions.
The problem is that the values returned from the managed bean interface is computed only on the currently active sessions. Based on the names of the methods, the values returned should be running totals, to include sessions that are no longer active.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DIRMINA-299) innacurate JMX statistics
Posted by "Julien Vermillard (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-299?page=comments#action_12445844 ]
Julien Vermillard commented on DIRMINA-299:
-------------------------------------------
Thanks for this very interesting patch !
I'm going to take a look when I got a free moment.
> innacurate JMX statistics
> -------------------------
>
> Key: DIRMINA-299
> URL: http://issues.apache.org/jira/browse/DIRMINA-299
> Project: Directory MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1
> Environment: Fedora Core 5, Eclipse 3.2 using Java 1.4 compiler settings.
> Reporter: Mark Webb
> Priority: Minor
> Attachments: jmx.diff
>
>
> The class org.apache.mina.integration.jmx.IoServiceManager computes the bytes read/written using the service's managed sessions using the method IoService.getManagedSessions(). This method returns a java.util.Set object, which only contains the sessions currently active.
> The IoServiceManager class uses org.apache.mina.management.StatCollector class to assist with tracking data throughput. The StatCollector class only operates on active sessions.
> The problem is that the values returned from the managed bean interface is computed only on the currently active sessions. Based on the names of the methods, the values returned should be running totals, to include sessions that are no longer active.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (DIRMINA-299) innacurate JMX statistics
Posted by "Julien Vermillard (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-299?page=all ]
Julien Vermillard reassigned DIRMINA-299:
-----------------------------------------
Assignee: Julien Vermillard
> innacurate JMX statistics
> -------------------------
>
> Key: DIRMINA-299
> URL: http://issues.apache.org/jira/browse/DIRMINA-299
> Project: Directory MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1
> Environment: Fedora Core 5, Eclipse 3.2 using Java 1.4 compiler settings.
> Reporter: Mark Webb
> Assigned To: Julien Vermillard
> Priority: Minor
> Attachments: jmx.diff
>
>
> The class org.apache.mina.integration.jmx.IoServiceManager computes the bytes read/written using the service's managed sessions using the method IoService.getManagedSessions(). This method returns a java.util.Set object, which only contains the sessions currently active.
> The IoServiceManager class uses org.apache.mina.management.StatCollector class to assist with tracking data throughput. The StatCollector class only operates on active sessions.
> The problem is that the values returned from the managed bean interface is computed only on the currently active sessions. Based on the names of the methods, the values returned should be running totals, to include sessions that are no longer active.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DIRMINA-299) innacurate JMX statistics
Posted by "Mark Webb (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-299?page=all ]
Mark Webb updated DIRMINA-299:
------------------------------
Attachment: JmxTestMain.java
JMX example main class
> innacurate JMX statistics
> -------------------------
>
> Key: DIRMINA-299
> URL: http://issues.apache.org/jira/browse/DIRMINA-299
> Project: Directory MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1
> Environment: Fedora Core 5, Eclipse 3.2 using Java 1.4 compiler settings.
> Reporter: Mark Webb
> Assigned To: Julien Vermillard
> Priority: Minor
> Fix For: 1.0.1, 1.1
>
> Attachments: HttpProtocolHandler.java, jmx.diff, JmxTestMain.java
>
>
> The class org.apache.mina.integration.jmx.IoServiceManager computes the bytes read/written using the service's managed sessions using the method IoService.getManagedSessions(). This method returns a java.util.Set object, which only contains the sessions currently active.
> The IoServiceManager class uses org.apache.mina.management.StatCollector class to assist with tracking data throughput. The StatCollector class only operates on active sessions.
> The problem is that the values returned from the managed bean interface is computed only on the currently active sessions. Based on the names of the methods, the values returned should be running totals, to include sessions that are no longer active.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DIRMINA-299) innacurate JMX statistics
Posted by "Mark Webb (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-299?page=all ]
Mark Webb updated DIRMINA-299:
------------------------------
Attachment: HttpProtocolHandler.java
Http Protocol Handler for the JMX example
> innacurate JMX statistics
> -------------------------
>
> Key: DIRMINA-299
> URL: http://issues.apache.org/jira/browse/DIRMINA-299
> Project: Directory MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1
> Environment: Fedora Core 5, Eclipse 3.2 using Java 1.4 compiler settings.
> Reporter: Mark Webb
> Assigned To: Julien Vermillard
> Priority: Minor
> Fix For: 1.0.1, 1.1
>
> Attachments: HttpProtocolHandler.java, jmx.diff, JmxTestMain.java
>
>
> The class org.apache.mina.integration.jmx.IoServiceManager computes the bytes read/written using the service's managed sessions using the method IoService.getManagedSessions(). This method returns a java.util.Set object, which only contains the sessions currently active.
> The IoServiceManager class uses org.apache.mina.management.StatCollector class to assist with tracking data throughput. The StatCollector class only operates on active sessions.
> The problem is that the values returned from the managed bean interface is computed only on the currently active sessions. Based on the names of the methods, the values returned should be running totals, to include sessions that are no longer active.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DIRMINA-299) innacurate JMX statistics
Posted by "Mark Webb (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-299?page=comments#action_12450375 ]
Mark Webb commented on DIRMINA-299:
-----------------------------------
I have attached 2 files that would go into the example/src/main/java/org/apache/mina/example/jmx directory. All I have been doing is start JmxTestMain, then jconsole. I start collecting stats by clicking on the MBeans tab, then clicking the operations tab, and then pressing the startCollectingStats button.
I then run the following script:
while(true); do wget http://127.0.0.1:8080 ; rm -f index.html; sleep 2 ; done
Then refresh jconsole in order to view the updated statistics. You will see that the numbers are incorrect.
I will continue to work on this bug.
Thank you.
> innacurate JMX statistics
> -------------------------
>
> Key: DIRMINA-299
> URL: http://issues.apache.org/jira/browse/DIRMINA-299
> Project: Directory MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1
> Environment: Fedora Core 5, Eclipse 3.2 using Java 1.4 compiler settings.
> Reporter: Mark Webb
> Assigned To: Julien Vermillard
> Priority: Minor
> Fix For: 1.0.1, 1.1
>
> Attachments: HttpProtocolHandler.java, jmx.diff, JmxTestMain.java
>
>
> The class org.apache.mina.integration.jmx.IoServiceManager computes the bytes read/written using the service's managed sessions using the method IoService.getManagedSessions(). This method returns a java.util.Set object, which only contains the sessions currently active.
> The IoServiceManager class uses org.apache.mina.management.StatCollector class to assist with tracking data throughput. The StatCollector class only operates on active sessions.
> The problem is that the values returned from the managed bean interface is computed only on the currently active sessions. Based on the names of the methods, the values returned should be running totals, to include sessions that are no longer active.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DIRMINA-299) innacurate JMX statistics
Posted by "Mark Webb (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-299?page=comments#action_12450242 ]
Mark Webb commented on DIRMINA-299:
-----------------------------------
Great news. I would like to get a JMX example placed into the
examples directory, and then write documentation for this feature.
> innacurate JMX statistics
> -------------------------
>
> Key: DIRMINA-299
> URL: http://issues.apache.org/jira/browse/DIRMINA-299
> Project: Directory MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1
> Environment: Fedora Core 5, Eclipse 3.2 using Java 1.4 compiler settings.
> Reporter: Mark Webb
> Assigned To: Julien Vermillard
> Priority: Minor
> Fix For: 1.0.1, 1.1
>
> Attachments: jmx.diff
>
>
> The class org.apache.mina.integration.jmx.IoServiceManager computes the bytes read/written using the service's managed sessions using the method IoService.getManagedSessions(). This method returns a java.util.Set object, which only contains the sessions currently active.
> The IoServiceManager class uses org.apache.mina.management.StatCollector class to assist with tracking data throughput. The StatCollector class only operates on active sessions.
> The problem is that the values returned from the managed bean interface is computed only on the currently active sessions. Based on the names of the methods, the values returned should be running totals, to include sessions that are no longer active.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (DIRMINA-299) innacurate JMX statistics
Posted by "Julien Vermillard (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-299?page=all ]
Julien Vermillard resolved DIRMINA-299.
---------------------------------------
Fix Version/s: 2.0
Resolution: Fixed
fixed,
note : average fields for stateless IoService will display inccorect value, because the numer of opened session is nearly zero, all the time.
> innacurate JMX statistics
> -------------------------
>
> Key: DIRMINA-299
> URL: http://issues.apache.org/jira/browse/DIRMINA-299
> Project: MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1
> Environment: Fedora Core 5, Eclipse 3.2 using Java 1.4 compiler settings.
> Reporter: Mark Webb
> Assigned To: Julien Vermillard
> Priority: Minor
> Fix For: 1.0.1, 1.1, 2.0
>
> Attachments: HttpProtocolHandler.java, jmx.diff, JmxTestMain.java
>
>
> The class org.apache.mina.integration.jmx.IoServiceManager computes the bytes read/written using the service's managed sessions using the method IoService.getManagedSessions(). This method returns a java.util.Set object, which only contains the sessions currently active.
> The IoServiceManager class uses org.apache.mina.management.StatCollector class to assist with tracking data throughput. The StatCollector class only operates on active sessions.
> The problem is that the values returned from the managed bean interface is computed only on the currently active sessions. Based on the names of the methods, the values returned should be running totals, to include sessions that are no longer active.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (DIRMINA-299) innacurate JMX statistics
Posted by "Julien Vermillard (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-299?page=all ]
Julien Vermillard resolved DIRMINA-299.
---------------------------------------
Fix Version/s: 1.0.1
1.1
Resolution: Fixed
the patch had a few bug, like not computing the time between last session polling and session closing and other issues but the idea was correct. A side effect, watching serivce average and total throughput will prolly be less CPU intensive.
Commited in 1.0, 1.2 and trunk branches
> innacurate JMX statistics
> -------------------------
>
> Key: DIRMINA-299
> URL: http://issues.apache.org/jira/browse/DIRMINA-299
> Project: Directory MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1
> Environment: Fedora Core 5, Eclipse 3.2 using Java 1.4 compiler settings.
> Reporter: Mark Webb
> Assigned To: Julien Vermillard
> Priority: Minor
> Fix For: 1.0.1, 1.1
>
> Attachments: jmx.diff
>
>
> The class org.apache.mina.integration.jmx.IoServiceManager computes the bytes read/written using the service's managed sessions using the method IoService.getManagedSessions(). This method returns a java.util.Set object, which only contains the sessions currently active.
> The IoServiceManager class uses org.apache.mina.management.StatCollector class to assist with tracking data throughput. The StatCollector class only operates on active sessions.
> The problem is that the values returned from the managed bean interface is computed only on the currently active sessions. Based on the names of the methods, the values returned should be running totals, to include sessions that are no longer active.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (DIRMINA-299) innacurate JMX statistics
Posted by "Julien Vermillard (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-299?page=all ]
Julien Vermillard reopened DIRMINA-299:
---------------------------------------
You got a test case so I can try to debug it ?
> innacurate JMX statistics
> -------------------------
>
> Key: DIRMINA-299
> URL: http://issues.apache.org/jira/browse/DIRMINA-299
> Project: Directory MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1
> Environment: Fedora Core 5, Eclipse 3.2 using Java 1.4 compiler settings.
> Reporter: Mark Webb
> Assigned To: Julien Vermillard
> Priority: Minor
> Fix For: 1.1, 1.0.1
>
> Attachments: jmx.diff
>
>
> The class org.apache.mina.integration.jmx.IoServiceManager computes the bytes read/written using the service's managed sessions using the method IoService.getManagedSessions(). This method returns a java.util.Set object, which only contains the sessions currently active.
> The IoServiceManager class uses org.apache.mina.management.StatCollector class to assist with tracking data throughput. The StatCollector class only operates on active sessions.
> The problem is that the values returned from the managed bean interface is computed only on the currently active sessions. Based on the names of the methods, the values returned should be running totals, to include sessions that are no longer active.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DIRMINA-299) innacurate JMX statistics
Posted by "Mark Webb (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-299?page=all ]
Mark Webb updated DIRMINA-299:
------------------------------
Attachment: jmx.diff
This patch updates the following files:
integration-jmx/src/main/java/org/apache/mina/integration/jmx/IoServiceManager.java
integration-jmx/src/main/java/org/apache/mina/integration/jmx/IoServiceManagerMBean.java
core/src/main/java/org/apache/mina/management/StatCollector.java
What I did was use internal AtomicLong objects in StatCollector to store the values that were previously being computed on the fly. I chose AtomicLong to ensure thread safety. I also used a variant of the httpserver example to test the patch. Below is the code:
--BEGIN--
IoAcceptor acceptor = new SocketAcceptor();
// JMX Setup
IoServiceManager serviceManager = new IoServiceManager( acceptor );
MBeanServer mbs = ManagementFactory.getPlatformMBeanServer();
ObjectName name = new ObjectName("org.apache.mina.example.jmx:type=JmxTestMain");
mbs.registerMBean(serviceManager, name);
// Bind
acceptor.setLocalAddress( new InetSocketAddress( PORT ) );
acceptor.setHandler( new HttpProtocolHandler() );
acceptor.bind();
--END--
Compile and run this application. Start jconsole, click on the MBeans tab, select the proper bean name, select the Operations tab, and click startCollectingStats. Go back to the Attributes tab and click refresh. You will see the values being updated.
If you were to run the above scenario without the attached patch, you would get no values shown in the attribute tab.
> innacurate JMX statistics
> -------------------------
>
> Key: DIRMINA-299
> URL: http://issues.apache.org/jira/browse/DIRMINA-299
> Project: Directory MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1
> Environment: Fedora Core 5, Eclipse 3.2 using Java 1.4 compiler settings.
> Reporter: Mark Webb
> Priority: Minor
> Attachments: jmx.diff
>
>
> The class org.apache.mina.integration.jmx.IoServiceManager computes the bytes read/written using the service's managed sessions using the method IoService.getManagedSessions(). This method returns a java.util.Set object, which only contains the sessions currently active.
> The IoServiceManager class uses org.apache.mina.management.StatCollector class to assist with tracking data throughput. The StatCollector class only operates on active sessions.
> The problem is that the values returned from the managed bean interface is computed only on the currently active sessions. Based on the names of the methods, the values returned should be running totals, to include sessions that are no longer active.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DIRMINA-299) innacurate JMX statistics
Posted by "Mark Webb (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-299?page=comments#action_12450275 ]
Mark Webb commented on DIRMINA-299:
-----------------------------------
I tested the patch and it appears that the calculations are still not being performed properly. I will perform more testing and submit another path. I believe that we are close to the solution though :)
> innacurate JMX statistics
> -------------------------
>
> Key: DIRMINA-299
> URL: http://issues.apache.org/jira/browse/DIRMINA-299
> Project: Directory MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1
> Environment: Fedora Core 5, Eclipse 3.2 using Java 1.4 compiler settings.
> Reporter: Mark Webb
> Assigned To: Julien Vermillard
> Priority: Minor
> Fix For: 1.0.1, 1.1
>
> Attachments: jmx.diff
>
>
> The class org.apache.mina.integration.jmx.IoServiceManager computes the bytes read/written using the service's managed sessions using the method IoService.getManagedSessions(). This method returns a java.util.Set object, which only contains the sessions currently active.
> The IoServiceManager class uses org.apache.mina.management.StatCollector class to assist with tracking data throughput. The StatCollector class only operates on active sessions.
> The problem is that the values returned from the managed bean interface is computed only on the currently active sessions. Based on the names of the methods, the values returned should be running totals, to include sessions that are no longer active.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DIRMINA-299) innacurate JMX statistics
Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Trustin Lee updated DIRMINA-299:
--------------------------------
Fix Version/s: (was: 1.0.1)
(was: 1.1)
(was: 2.0)
1.0.2
> innacurate JMX statistics
> -------------------------
>
> Key: DIRMINA-299
> URL: https://issues.apache.org/jira/browse/DIRMINA-299
> Project: MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1
> Environment: Fedora Core 5, Eclipse 3.2 using Java 1.4 compiler settings.
> Reporter: Mark Webb
> Assigned To: Julien Vermillard
> Priority: Minor
> Fix For: 1.0.2
>
> Attachments: HttpProtocolHandler.java, jmx.diff, JmxTestMain.java
>
>
> The class org.apache.mina.integration.jmx.IoServiceManager computes the bytes read/written using the service's managed sessions using the method IoService.getManagedSessions(). This method returns a java.util.Set object, which only contains the sessions currently active.
> The IoServiceManager class uses org.apache.mina.management.StatCollector class to assist with tracking data throughput. The StatCollector class only operates on active sessions.
> The problem is that the values returned from the managed bean interface is computed only on the currently active sessions. Based on the names of the methods, the values returned should be running totals, to include sessions that are no longer active.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DIRMINA-299) innacurate JMX statistics
Posted by "Julien Vermillard (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-299?page=comments#action_12449996 ]
Julien Vermillard commented on DIRMINA-299:
-------------------------------------------
good patch, fixing the problem with bytes not added to the stats when the session close, but it's also removing per session statistics which is used for connected prtocols with long session lifetime.
I'm going to work on a compromise for keep per session stats.
It's definitively a bug affecting 1.0 and later versions.
> innacurate JMX statistics
> -------------------------
>
> Key: DIRMINA-299
> URL: http://issues.apache.org/jira/browse/DIRMINA-299
> Project: Directory MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1
> Environment: Fedora Core 5, Eclipse 3.2 using Java 1.4 compiler settings.
> Reporter: Mark Webb
> Assigned To: Julien Vermillard
> Priority: Minor
> Attachments: jmx.diff
>
>
> The class org.apache.mina.integration.jmx.IoServiceManager computes the bytes read/written using the service's managed sessions using the method IoService.getManagedSessions(). This method returns a java.util.Set object, which only contains the sessions currently active.
> The IoServiceManager class uses org.apache.mina.management.StatCollector class to assist with tracking data throughput. The StatCollector class only operates on active sessions.
> The problem is that the values returned from the managed bean interface is computed only on the currently active sessions. Based on the names of the methods, the values returned should be running totals, to include sessions that are no longer active.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DIRMINA-299) innacurate JMX statistics
Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-299?page=comments#action_12453838 ]
Trustin Lee commented on DIRMINA-299:
-------------------------------------
Mark, will this be fixed before 1.0.1 release (will cut the release tomorrow)?
> innacurate JMX statistics
> -------------------------
>
> Key: DIRMINA-299
> URL: http://issues.apache.org/jira/browse/DIRMINA-299
> Project: MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1
> Environment: Fedora Core 5, Eclipse 3.2 using Java 1.4 compiler settings.
> Reporter: Mark Webb
> Assigned To: Julien Vermillard
> Priority: Minor
> Fix For: 1.0.1, 1.1
>
> Attachments: HttpProtocolHandler.java, jmx.diff, JmxTestMain.java
>
>
> The class org.apache.mina.integration.jmx.IoServiceManager computes the bytes read/written using the service's managed sessions using the method IoService.getManagedSessions(). This method returns a java.util.Set object, which only contains the sessions currently active.
> The IoServiceManager class uses org.apache.mina.management.StatCollector class to assist with tracking data throughput. The StatCollector class only operates on active sessions.
> The problem is that the values returned from the managed bean interface is computed only on the currently active sessions. Based on the names of the methods, the values returned should be running totals, to include sessions that are no longer active.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira