[jira] [Commented] (BEAM-812) Shade guava in beam-sdks-java-io-google-cloud-platform

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15604015#comment-15604015 ] 

ASF GitHub Bot commented on BEAM-812:
-------------------------------------

GitHub user dhalperi opened a pull request:

    https://github.com/apache/incubator-beam/pull/1183

    [BEAM-812] gcp-io: add ApiSurfaceTest

    Copied from SDK, but I manually recreated/verified the whitelist.
    
    Surely there are refactoring improvements to be had so that we can more easily
    reuse ApiSurface across modules.
    
    R: @kennknowles 
    R: @davorbonaci 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/incubator-beam dataflow-gcp-shade

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1183.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1183
    
----
commit 0cf01507324216771c21587c205fbce1a94e14a0
Author: Dan Halperin <dh...@google.com>
Date:   2016-10-25T03:08:20Z

    gcp-io: add ApiSurfaceTest
    
    Copied from SDK, but I manually recreated the whitelist.
    
    Surely there are refactoring improvements to be had so that we can more easily
    reuse ApiSurface across modules.

----


> Shade guava in beam-sdks-java-io-google-cloud-platform
> ------------------------------------------------------
>
>                 Key: BEAM-812
>                 URL: https://issues.apache.org/jira/browse/BEAM-812
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-gcp
>            Reporter: Daniel Halperin
>            Assignee: Daniel Halperin
>             Fix For: 0.4.0-incubating
>
>
> Looking at 0.3.0-incubating RC1, we are not properly shading Guava.
> https://repository.apache.org/content/repositories/staging/org/apache/beam/beam-sdks-java-io-google-cloud-platform/0.3.0-incubating/beam-sdks-java-io-google-cloud-platform-0.3.0-incubating.pom
> has 
> {code}
> <dependency>
>   <groupId>com.google.guava</groupId>
>   <artifactId>guava</artifactId>
> </dependency
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)