You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/06/23 06:31:49 UTC

[GitHub] [iotdb] irvine0109 commented on a diff in pull request #6391: [IOTDB-3622] Use symlink to decrease the copied file size in cluster test

irvine0109 commented on code in PR #6391:
URL: https://github.com/apache/iotdb/pull/6391#discussion_r904628744


##########
integration-test/src/main/java/org/apache/iotdb/it/env/AbstractNodeWrapper.java:
##########
@@ -79,14 +83,32 @@ public AbstractNodeWrapper(String testClassName, String testMethodName, int[] po
   @Override
   public void createDir() {
     // Copy templateNodePath to nodePath
+    String destPath = getNodePath();
     try {
-      File nodeDir = new File(getNodePath());
+      File nodeDir = new File(destPath);
       try {
         FileUtils.forceDelete(nodeDir);

Review Comment:
   Use PathUtils.deleteDirectory() instead of FileUtils.forceDelete()?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org