You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "abandy (via GitHub)" <gi...@apache.org> on 2024/02/02 14:20:49 UTC
[PR] GH-39910: [Go] Add func to load prepared statement from ActionCreatePreparedStatementResult [arrow]
abandy opened a new pull request, #39913:
URL: https://github.com/apache/arrow/pull/39913
Currently, in order to create a PreparedStatement a DoAction call will always be made via the client. I need to be able to make a PreparedStatement from persisted data that will not trigger the DoAction call to the server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39910: [Go] Add func to load prepared statement from ActionCreatePreparedStatementResult [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #39913:
URL: https://github.com/apache/arrow/pull/39913#issuecomment-1933270896
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit f609bb171a8bce973d7b040d8684b04a60e806ed.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/21346141311) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39910: [Go] Add func to load prepared statement from ActionCreatePreparedStatementResult [arrow]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #39913:
URL: https://github.com/apache/arrow/pull/39913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39910: [Go] Add func to load prepared statement from ActionCreatePreparedStatementResult [arrow]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #39913:
URL: https://github.com/apache/arrow/pull/39913#issuecomment-1932887124
Thanks @abandy!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39910: [Go] Add func to load prepared statement from ActionCreatePreparedStatementResult [arrow]
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on PR #39913:
URL: https://github.com/apache/arrow/pull/39913#issuecomment-1930095915
Updated the Load prepared statement to use a type defined in types.go and added a func that allows the prepared statement to execute a put without returning a flightinfo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39910: [Go] Add func to load prepared statement from ActionCreatePreparedStatementResult [arrow]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #39913:
URL: https://github.com/apache/arrow/pull/39913#discussion_r1478426763
##########
go/arrow/flight/flightsql/client.go:
##########
@@ -450,6 +450,31 @@ func (c *Client) PrepareSubstrait(ctx context.Context, plan SubstraitPlan, opts
return parsePreparedStatementResponse(c, c.Alloc, stream)
}
+func (c *Client) LoadPreparedStatementFromResult(result *pb.ActionCreatePreparedStatementResult) (*PreparedStatement, error) {
Review Comment:
rather than exposing the `pb.ActionCreatePreparedStatementResult` directly, please add a type for it in `types.go` with the other protobuf aliasing we do instead. We try to avoid using the protobuf types *directly* in the interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39910: [Go] Add func to load prepared statement from ActionCreatePreparedStatementResult [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39913:
URL: https://github.com/apache/arrow/pull/39913#issuecomment-1923986797
:warning: GitHub issue #39910 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org