You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "desaikomal (via GitHub)" <gi...@apache.org> on 2023/05/22 16:38:08 UTC
[GitHub] [helix] desaikomal opened a new pull request, #2502: Fixes #324 - Callback Handler messages
desaikomal opened a new pull request, #2502:
URL: https://github.com/apache/helix/pull/2502
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
Fixes #324
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
This PR was filed to make sure that we have all the required level of logs in CallbackHandler. Some of the messages are at Debug level and do we need them promoted to Info level. I have gone through the whole file and made sure we have proper level of logs.
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- The following is the result of the "mvn test" command on the appropriate module:
mvn test (in helix-core is in progress).
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on a diff in pull request #2502: Fixes #324 - Callback Handler messages
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on code in PR #2502:
URL: https://github.com/apache/helix/pull/2502#discussion_r1201196711
##########
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java:
##########
@@ -747,7 +752,7 @@ public void reset() {
reset(true);
}
- void reset(boolean isShutdown) {
+ public void reset(boolean isShutdown) {
Review Comment:
yes, there are others who are calling this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu merged pull request #2502: Fixes #324 - Callback Handler messages
Posted by "xyuanlu (via GitHub)" <gi...@apache.org>.
xyuanlu merged PR #2502:
URL: https://github.com/apache/helix/pull/2502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on a diff in pull request #2502: Fixes #324 - Callback Handler messages
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on code in PR #2502:
URL: https://github.com/apache/helix/pull/2502#discussion_r1201197568
##########
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java:
##########
@@ -747,7 +752,7 @@ public void reset() {
reset(true);
}
- void reset(boolean isShutdown) {
+ public void reset(boolean isShutdown) {
Review Comment:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project helix-core: Compilation failure: Compilation failure:
[ERROR] /Users/kdesai/experiment/helix/helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java:[384,16] reset(boolean) has private access in org.apache.helix.manager.zk.CallbackHandler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on a diff in pull request #2502: Fixes #324 - Callback Handler messages
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on code in PR #2502:
URL: https://github.com/apache/helix/pull/2502#discussion_r1201191862
##########
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java:
##########
@@ -788,9 +792,23 @@ public boolean isReady() {
}
public String getContent() {
- return "CallbackHandler{" + "_watchChild=" + _watchChild + ", _preFetchEnabled="
- + _preFetchEnabled + ", _batchModeEnabled=" + _batchModeEnabled + ", _path='" + _path + '\''
- + ", _listener=" + _listener + ", _changeType=" + _changeType + ", _manager=" + _manager
- + ", _zkClient=" + _zkClient + '}';
+ StringBuilder sb = new StringBuilder("iCallbackHandler{_watchChild=");
Review Comment:
yes, as i can't adjust font size in IDE and my eyesight is really bad right now (it will become better post july-31st)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on a diff in pull request #2502: Fixes #324 - Callback Handler messages
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on code in PR #2502:
URL: https://github.com/apache/helix/pull/2502#discussion_r1201192537
##########
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java:
##########
@@ -788,9 +792,23 @@ public boolean isReady() {
}
public String getContent() {
- return "CallbackHandler{" + "_watchChild=" + _watchChild + ", _preFetchEnabled="
- + _preFetchEnabled + ", _batchModeEnabled=" + _batchModeEnabled + ", _path='" + _path + '\''
- + ", _listener=" + _listener + ", _changeType=" + _changeType + ", _manager=" + _manager
- + ", _zkClient=" + _zkClient + '}';
+ StringBuilder sb = new StringBuilder("iCallbackHandler{_watchChild=");
+ sb.append(_watchChild);
+ sb.append(", _preFetchEnabled=");
+ sb.append(_preFetchEnabled);
+ sb.append(", _batchModeEnabled=");
+ sb.append(_batchModeEnabled);
+ sb.append(", _path='");
+ sb.append(_path);
+ sb.append("', _listener=");
Review Comment:
no, this is not extra, path, has 'path'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on pull request #2502: Fixes #324 - Callback Handler messages
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on PR #2502:
URL: https://github.com/apache/helix/pull/2502#issuecomment-1559869277
This PR is ready to be merged. Thanks @xyuanlu for reviewing and approving the request.
Commit message: Change CallbackHandler messages for debuggability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] qqu0127 commented on a diff in pull request #2502: Fixes #324 - Callback Handler messages
Posted by "qqu0127 (via GitHub)" <gi...@apache.org>.
qqu0127 commented on code in PR #2502:
URL: https://github.com/apache/helix/pull/2502#discussion_r1201042554
##########
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java:
##########
@@ -788,9 +792,23 @@ public boolean isReady() {
}
public String getContent() {
- return "CallbackHandler{" + "_watchChild=" + _watchChild + ", _preFetchEnabled="
- + _preFetchEnabled + ", _batchModeEnabled=" + _batchModeEnabled + ", _path='" + _path + '\''
- + ", _listener=" + _listener + ", _changeType=" + _changeType + ", _manager=" + _manager
- + ", _zkClient=" + _zkClient + '}';
+ StringBuilder sb = new StringBuilder("iCallbackHandler{_watchChild=");
Review Comment:
extra i here.
(Did you edit all these in vim? :D
##########
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java:
##########
@@ -747,7 +752,7 @@ public void reset() {
reset(true);
}
- void reset(boolean isShutdown) {
+ public void reset(boolean isShutdown) {
Review Comment:
is this necessary?
##########
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java:
##########
@@ -788,9 +792,23 @@ public boolean isReady() {
}
public String getContent() {
- return "CallbackHandler{" + "_watchChild=" + _watchChild + ", _preFetchEnabled="
- + _preFetchEnabled + ", _batchModeEnabled=" + _batchModeEnabled + ", _path='" + _path + '\''
- + ", _listener=" + _listener + ", _changeType=" + _changeType + ", _manager=" + _manager
- + ", _zkClient=" + _zkClient + '}';
+ StringBuilder sb = new StringBuilder("iCallbackHandler{_watchChild=");
+ sb.append(_watchChild);
+ sb.append(", _preFetchEnabled=");
+ sb.append(_preFetchEnabled);
+ sb.append(", _batchModeEnabled=");
+ sb.append(_batchModeEnabled);
+ sb.append(", _path='");
+ sb.append(_path);
+ sb.append("', _listener=");
Review Comment:
extra '
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org