[jira] [Commented] (AIRFLOW-2979) Deprecated Celery Option not in Options list

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599475#comment-16599475 ] 

ASF GitHub Bot commented on AIRFLOW-2979:
-----------------------------------------

kaxil opened a new pull request #3832: [AIRFLOW-2979] Make celery_result_backend conf Backwards compatible
URL: https://github.com/apache/incubator-airflow/pull/3832
 
 
   
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-2979
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   (#2806) Renamed `celery_result_backend` to `result_backend` and broke backwards compatibility.
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
   
   ### Code Quality
   
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Deprecated Celery Option not in Options list 
> ---------------------------------------------
>
>                 Key: AIRFLOW-2979
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2979
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: celery
>    Affects Versions: 1.10.0
>            Reporter: Micheal Ascah
>            Assignee: Kaxil Naik
>            Priority: Critical
>
> References AIRFLOW-1840
> In airflow/configuration.py
> {code:java}
> # A two-level mapping of (section -> new_name -> old_name). When reading
> # new_name, the old_name will be checked to see if it exists. If it does a
> # DeprecationWarning will be issued and the old name will be used instead
> deprecated_options = {
>     'celery': {
>         # Remove these keys in Airflow 1.11
>         'worker_concurrency': 'celeryd_concurrency',
>         'broker_url': 'celery_broker_url',
>         'ssl_active': 'celery_ssl_active',
>         'ssl_cert': 'celery_ssl_cert',
>         'ssl_key': 'celery_ssl_key',
>     }
> }
> {code}
> This block is missing the renaming of celery_result_backend to just result_backed.
>  
> When setting this through an environment variable, the deprecated config name is not being used and instead the default value in the file is being used. 
> This is obviously remedied by the reading the UPDATING and setting the new name, but this change has broken back compat as far as I can tell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)