You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/12/08 18:10:07 UTC
[kudu-CR] Make delete table-test less flaky
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5421
to review the following change.
Change subject: Make delete_table-test less flaky
......................................................................
Make delete_table-test less flaky
This patch reduces the flakiness of delete_table-test by solving
flakiness problems on two individual tests:
1. DeleteTableTest.TestAutoTombstoneAfterTabletCopyRemoteFails
This test triggers a remote crash that would sometimes prevent an RPC
response from arriving at the caller. We now account for this.
2. DeleteTableTombstonedParamTest.TestTabletTombstone
This test would sometimes not write quickly enough, resulting in a
timeout waiting for 3 wal files to appear on tablet 0. This could occur
when running under TSAN on a system under heavy load.
Now, the above two tests run successfully in 200/200 attempts on TSAN
under load.
This patch does not address the flakiness of
DeleteTableTest.TestDeleteTableWithConcurrentWrites yet. That test has
two issues that are being tracked as KUDU-1294 and KUDU-1797.
However a log message has been added to this commit to aid in debugging
that test in a later patch.
Change-Id: Iea7760009acc8a795225369721af97583974feba
---
M src/kudu/integration-tests/delete_table-test.cc
1 file changed, 22 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/5421/1
--
To view, visit http://gerrit.cloudera.org:8080/5421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea7760009acc8a795225369721af97583974feba
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Make delete table-test less flaky
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Make delete_table-test less flaky
......................................................................
Patch Set 1:
(1 comment)
how about TabletCopyClientSessionITest.TestStartTabletCopyWhileSourceBootstrapping ? it's also flaky in TSAN
http://gerrit.cloudera.org:8080/#/c/5421/1/src/kudu/integration-tests/delete_table-test.cc
File src/kudu/integration-tests/delete_table-test.cc:
PS1, Line 1199: // Breaks here (found 2 !?!)
?
--
To view, visit http://gerrit.cloudera.org:8080/5421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea7760009acc8a795225369721af97583974feba
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Make delete table-test less flaky
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5421
to look at the new patch set (#2).
Change subject: Make delete_table-test less flaky
......................................................................
Make delete_table-test less flaky
This patch reduces the flakiness of delete_table-test by solving
flakiness problems on two individual tests:
1. DeleteTableTest.TestAutoTombstoneAfterTabletCopyRemoteFails
This test triggers a remote crash that would sometimes prevent an RPC
response from arriving at the caller. We now account for this.
2. DeleteTableTombstonedParamTest.TestTabletTombstone
This test would sometimes not write quickly enough, resulting in a
timeout waiting for 3 wal files to appear on tablet 0. This could occur
when running under TSAN on a system under heavy load.
Now, the above two tests run successfully in 200/200 attempts on TSAN
under load.
This patch does not address the flakiness of
DeleteTableTest.TestDeleteTableWithConcurrentWrites yet. That test has
two issues that are being tracked as KUDU-1294 and KUDU-1797.
However a log message has been added to this commit to aid in debugging
that test in a later patch.
Change-Id: Iea7760009acc8a795225369721af97583974feba
---
M src/kudu/integration-tests/delete_table-test.cc
1 file changed, 21 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/5421/2
--
To view, visit http://gerrit.cloudera.org:8080/5421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea7760009acc8a795225369721af97583974feba
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Make delete table-test less flaky
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Make delete_table-test less flaky
......................................................................
Patch Set 1:
> > how about TabletCopyClientSessionITest.TestStartTabletCopyWhileSourceBootstrapping
Oops, forget what I just said. That is a different test, right?
--
To view, visit http://gerrit.cloudera.org:8080/5421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea7760009acc8a795225369721af97583974feba
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Make delete table-test less flaky
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Make delete_table-test less flaky
......................................................................
Patch Set 1:
(1 comment)
> (1 comment)
>
> how about TabletCopyClientSessionITest.TestStartTabletCopyWhileSourceBootstrapping
> ? it's also flaky in TSAN
That one passes 200/200 for me now when run with
KUDU_ALLOW_SLOW_TESTS=1 ../../build-support/dist_test.py --collect-tmpdir --disable-sharding loop --num-instances 200 -- bin/delete_table-test --stress_cpu_threads=8 --gtest_filter=TabletCopyClientSessionITest.TestStartTabletCopyWhileSourceBootstrapping
Results at http://dist-test.cloudera.org/job?job_id=mpercy.1481293581.9054
http://gerrit.cloudera.org:8080/#/c/5421/1/src/kudu/integration-tests/delete_table-test.cc
File src/kudu/integration-tests/delete_table-test.cc:
PS1, Line 1199: // Breaks here (found 2 !?!)
> ?
Oops, missed a note I left to myself in here
--
To view, visit http://gerrit.cloudera.org:8080/5421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea7760009acc8a795225369721af97583974feba
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Make delete table-test less flaky
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Make delete_table-test less flaky
......................................................................
Patch Set 2: Code-Review+2
Yes, was referring to a different test that also seems flaky.
--
To view, visit http://gerrit.cloudera.org:8080/5421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea7760009acc8a795225369721af97583974feba
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Make delete table-test less flaky
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Make delete_table-test less flaky
......................................................................
Make delete_table-test less flaky
This patch reduces the flakiness of delete_table-test by solving
flakiness problems on two individual tests:
1. DeleteTableTest.TestAutoTombstoneAfterTabletCopyRemoteFails
This test triggers a remote crash that would sometimes prevent an RPC
response from arriving at the caller. We now account for this.
2. DeleteTableTombstonedParamTest.TestTabletTombstone
This test would sometimes not write quickly enough, resulting in a
timeout waiting for 3 wal files to appear on tablet 0. This could occur
when running under TSAN on a system under heavy load.
Now, the above two tests run successfully in 200/200 attempts on TSAN
under load.
This patch does not address the flakiness of
DeleteTableTest.TestDeleteTableWithConcurrentWrites yet. That test has
two issues that are being tracked as KUDU-1294 and KUDU-1797.
However a log message has been added to this commit to aid in debugging
that test in a later patch.
Change-Id: Iea7760009acc8a795225369721af97583974feba
Reviewed-on: http://gerrit.cloudera.org:8080/5421
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/integration-tests/delete_table-test.cc
1 file changed, 21 insertions(+), 2 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea7760009acc8a795225369721af97583974feba
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>