You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2021/01/19 08:06:03 UTC

[GitHub] [thrift] sveneld opened a new pull request #2306: THRIFT-5336 Add possibility to setup connection timeout in TCurlClient

sveneld opened a new pull request #2306:
URL: https://github.com/apache/thrift/pull/2306


   Add possibility to setup connection timeout in TCurlClient
   
   In TCurlClient we can set only total timeout, it will be great to have opportunity to set connection timeout 
     
   
   
   - [+] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [+] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [+] Did you squash your changes to a single commit?  (not required, but preferred)
   - [+] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G commented on pull request #2306: THRIFT-5336 Add possibility to setup connection timeout in TCurlClient

Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2306:
URL: https://github.com/apache/thrift/pull/2306#issuecomment-766332264


   You mean possible like in "technically possible"or more like "could somebody pls review and merge?"


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] sveneld commented on pull request #2306: THRIFT-5336 Add possibility to setup connection timeout in TCurlClient

Posted by GitBox <gi...@apache.org>.
sveneld commented on pull request #2306:
URL: https://github.com/apache/thrift/pull/2306#issuecomment-763974877


   @Jens-G @ulidtko Please take attention to this pull request


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] sveneld commented on pull request #2306: THRIFT-5336 Add possibility to setup connection timeout in TCurlClient

Posted by GitBox <gi...@apache.org>.
sveneld commented on pull request #2306:
URL: https://github.com/apache/thrift/pull/2306#issuecomment-766333294


   Thank you :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] sveneld commented on pull request #2306: THRIFT-5336 Add possibility to setup connection timeout in TCurlClient

Posted by GitBox <gi...@apache.org>.
sveneld commented on pull request #2306:
URL: https://github.com/apache/thrift/pull/2306#issuecomment-766137780


   @Jens-G is it possible to merge this pull request before release 0.14?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] sveneld commented on pull request #2306: THRIFT-5336 Add possibility to setup connection timeout in TCurlClient

Posted by GitBox <gi...@apache.org>.
sveneld commented on pull request #2306:
URL: https://github.com/apache/thrift/pull/2306#issuecomment-763974877


   @Jens-G @ulidtko Please take attention to this pull request


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G closed pull request #2306: THRIFT-5336 Add possibility to setup connection timeout in TCurlClient

Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2306:
URL: https://github.com/apache/thrift/pull/2306


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org