You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2016/03/31 15:47:17 UTC
[GitHub] brooklyn-server pull request: Fix noConsoleSecurity option
GitHub user neykov opened a pull request:
https://github.com/apache/brooklyn-server/pull/94
Fix noConsoleSecurity option
Also skip security by default for tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/brooklyn-server fix/tests-skip-security
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/94.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #94
----
commit c5c2380a221f6e383243b327d51e2a1923fdd36c
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2016-03-31T09:45:20Z
Fix noConsoleSecurity option
Also skip security by default for BrooklynRestApiLauncher.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: Fix noConsoleSecurity option
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/94
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: Fix noConsoleSecurity option
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/94#discussion_r58075813
--- Diff: rest/rest-server-jersey/src/test/java/org/apache/brooklyn/rest/BrooklynRestApiLauncherTest.java ---
@@ -36,17 +36,17 @@
public class BrooklynRestApiLauncherTest extends BrooklynRestApiLauncherTestFixture {
- @Test
+ @Test(enabled = false) // to be deleted
--- End diff --
Yes, but doesn't really matter because already deleted in https://github.com/apache/brooklyn-server/pull/95.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: Fix noConsoleSecurity option
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-server/pull/94#issuecomment-203985765
btw forgot to mention that this fixes the master build tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: Fix noConsoleSecurity option
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/94#discussion_r58075531
--- Diff: rest/rest-server-jersey/src/test/java/org/apache/brooklyn/rest/BrooklynRestApiLauncherTest.java ---
@@ -36,17 +36,17 @@
public class BrooklynRestApiLauncherTest extends BrooklynRestApiLauncherTestFixture {
- @Test
+ @Test(enabled = false) // to be deleted
--- End diff --
Can these tests just be deleted?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: Fix noConsoleSecurity option
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/brooklyn-server/pull/94#issuecomment-203993162
@neykov Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---