[jira] [Commented] (SHIRO-618) Spring Boot Web Starter- Autoconfiguration for Realm and ShiroFilterChainDefinition

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHIRO-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990631#comment-15990631 ] 

ASF GitHub Bot commented on SHIRO-618:
--------------------------------------

Github user MarcGiffing closed the pull request at:

    https://github.com/apache/shiro/pull/62


> Spring Boot Web Starter- Autoconfiguration for Realm and ShiroFilterChainDefinition
> -----------------------------------------------------------------------------------
>
>                 Key: SHIRO-618
>                 URL: https://issues.apache.org/jira/browse/SHIRO-618
>             Project: Shiro
>          Issue Type: Improvement
>            Reporter: Marc G.
>             Fix For: 1.4.0
>
>
> After adding the spring-boot-web-starter you got the exception that two beans are missing.
> * Realm
> * ShiroFilterChainDefinition
> Are they not defined on purpose? Both can be provided as a default with @ConditionalOnMissingBean.
> A default TextConfigurationRealm could be configured with properties.
> Providing defaults makes it easier to get startet. 
> I could provide a pull request if desired.
> What do you think?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)