You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/01 17:01:17 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #8813: [license] Add notice files for binary release
morningman opened a new pull request #8813:
URL: https://github.com/apache/incubator-doris/pull/8813
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
For binary release, if a dependency has NOTICE file, we need to copy it to the binary release package.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #8813: [license] Add notice files for binary release
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #8813:
URL: https://github.com/apache/incubator-doris/pull/8813#discussion_r841004694
##########
File path: dist/licenses/LICENSE.jboss-marshalling.txt
##########
@@ -0,0 +1,179 @@
+
+ Apache License
+ Version 2.0, January 2004
+ https://www.apache.org/licenses/
+
+ TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+ 1. Definitions.
+
+ "License" shall mean the terms and conditions for use, reproduction,
Review comment:
The file is referenced in NOTICE-dist.txt (Content of NOTICE for hadoop-auth-2.8.0). So I had to add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8813: [license] Add notice files for binary release
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8813:
URL: https://github.com/apache/incubator-doris/pull/8813#issuecomment-1086566127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] CalvinKirs commented on pull request #8813: [license] Add notice files for binary release
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #8813:
URL: https://github.com/apache/incubator-doris/pull/8813#issuecomment-1086527750
As far as i know, we have three binary packages, we'd better create the corresponding directory separately to manage the corresponding License and NOTICE,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #8813: [license] Add notice files for binary release
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #8813:
URL: https://github.com/apache/incubator-doris/pull/8813#issuecomment-1086591710
> As far as i know, we have three binary packages, we'd better create the corresponding directory separately to manage the corresponding License and NOTICE,
ok, i see
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #8813: [license] Add notice files for binary release
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #8813:
URL: https://github.com/apache/incubator-doris/pull/8813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] CalvinKirs commented on a change in pull request #8813: [license] Add notice files for binary release
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #8813:
URL: https://github.com/apache/incubator-doris/pull/8813#discussion_r840999194
##########
File path: dist/licenses/LICENSE.jboss-marshalling.txt
##########
@@ -0,0 +1,179 @@
+
+ Apache License
+ Version 2.0, January 2004
+ https://www.apache.org/licenses/
+
+ TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+ 1. Definitions.
+
+ "License" shall mean the terms and conditions for use, reproduction,
Review comment:
With a standard AL2 like this, we don't need to add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org