You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/08/06 12:34:47 UTC
[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #675: add Schema Disable Config #674
tianxiaoliang commented on a change in pull request #675:
URL: https://github.com/apache/servicecomb-service-center/pull/675#discussion_r466379184
##########
File path: server/rest/controller/v4/schema_controller.go
##########
@@ -36,15 +36,30 @@ type SchemaService struct {
}
func (s *SchemaService) URLPatterns() []rest.Route {
+ if !core.ServerInfo.Config.SchemaDisable {
+ return []rest.Route{
+ {Method: rest.HTTPMethodGet, Path: "/v4/:project/registry/microservices/:serviceId/schemas/:schemaId", Func: s.GetSchemas},
Review comment:
in fact you only need to disable ModifySchema，in another hand this is not clean code.
plz only use core.ServerInfo.Config.SchemaDisable in ModifySchema function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org