Merge pull request using zk-merge-pr.py script

[Rakesh Radhakrishnan <ra...@apache.org>]

Hi,

I have an observation about the merge PR python script.
https://cwiki.apache.org/confluence/display/ZOOKEEPER/Committing+changes

I could see the commit made using this automated merge script is missing to
edit the 'CHANGES.TXT' file and then add the jira details that correspond
to the patch. I feel, there is an inconsistency between the commit that
goes via manually and automated script. Welcome comments?

Thanks & Regards,
Rakesh

Re: Merge pull request using zk-merge-pr.py script

[Michael Han <ha...@cloudera.com>]

Maybe it's a good time to automate change log generation. Example:
https://issues.apache.org/jira/browse/HADOOP-11731

On Thu, Dec 15, 2016 at 10:04 PM, Rakesh Radhakrishnan <
rakeshr.apache@gmail.com> wrote:

> Before migrating to git, committer has to update the CHANGE.TXT file
> manually and then push this along with the approved patch as a single
> commit.
>
> Thanks,
> Rakesh
>
> On 16-Dec-2016 11:16 AM, "Michael Han" <ha...@cloudera.com> wrote:
>
> Good catch, I think a couple of recent commits on master branch missing
> editing of CHANGE.TXT
>
> How is CHANGE.TXT edited before migrating to git during a commit? Is it
> done automatically or manually (that a committer has to update the file)?
>
> On Thu, Dec 15, 2016 at 8:32 PM, Rakesh Radhakrishnan <ra...@apache.org>
> wrote:
>
> > Hi,
> >
> > I have an observation about the merge PR python script.
> > https://cwiki.apache.org/confluence/display/ZOOKEEPER/Committing+changes
> >
> > I could see the commit made using this automated merge script is missing
> to
> > edit the 'CHANGES.TXT' file and then add the jira details that correspond
> > to the patch. I feel, there is an inconsistency between the commit that
> > goes via manually and automated script. Welcome comments?
> >
> > Thanks & Regards,
> > Rakesh
> >
>
>
>
> --
> Cheers
> Michael.
>



-- 
Cheers
Michael.

Re: Merge pull request using zk-merge-pr.py script

[Rakesh Radhakrishnan <ra...@gmail.com>]

Before migrating to git, committer has to update the CHANGE.TXT file
manually and then push this along with the approved patch as a single
commit.

Thanks,
Rakesh

On 16-Dec-2016 11:16 AM, "Michael Han" <ha...@cloudera.com> wrote:

Good catch, I think a couple of recent commits on master branch missing
editing of CHANGE.TXT

How is CHANGE.TXT edited before migrating to git during a commit? Is it
done automatically or manually (that a committer has to update the file)?

On Thu, Dec 15, 2016 at 8:32 PM, Rakesh Radhakrishnan <ra...@apache.org>
wrote:

> Hi,
>
> I have an observation about the merge PR python script.
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/Committing+changes
>
> I could see the commit made using this automated merge script is missing
to
> edit the 'CHANGES.TXT' file and then add the jira details that correspond
> to the patch. I feel, there is an inconsistency between the commit that
> goes via manually and automated script. Welcome comments?
>
> Thanks & Regards,
> Rakesh
>



--
Cheers
Michael.

Re: Merge pull request using zk-merge-pr.py script

[Michael Han <ha...@cloudera.com>]

Good catch, I think a couple of recent commits on master branch missing
editing of CHANGE.TXT

How is CHANGE.TXT edited before migrating to git during a commit? Is it
done automatically or manually (that a committer has to update the file)?

On Thu, Dec 15, 2016 at 8:32 PM, Rakesh Radhakrishnan <ra...@apache.org>
wrote:

> Hi,
>
> I have an observation about the merge PR python script.
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/Committing+changes
>
> I could see the commit made using this automated merge script is missing to
> edit the 'CHANGES.TXT' file and then add the jira details that correspond
> to the patch. I feel, there is an inconsistency between the commit that
> goes via manually and automated script. Welcome comments?
>
> Thanks & Regards,
> Rakesh
>



-- 
Cheers
Michael.