You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/05/31 09:08:35 UTC

[GitHub] [calcite] wenhuitang commented on a change in pull request #800: [CALCITE-2460][CALCITE-2459] Add implementation of To_Base64 and From_Base64 to SqlFunctions

wenhuitang commented on a change in pull request #800: [CALCITE-2460][CALCITE-2459] Add implementation of To_Base64 and  From_Base64 to SqlFunctions
URL: https://github.com/apache/calcite/pull/800#discussion_r289312766
 
 

 ##########
 File path: src/main/config/checkstyle/checker.xml
 ##########
 @@ -95,7 +95,7 @@ limitations under the License.
     <module name="EqualsHashCode"/>
       <!-- Disallow unnecessary instantiation of Boolean, String -->
     <module name="IllegalInstantiation">
-      <property name="classes" value="java.lang.Boolean, java.lang.String"/>
 
 Review comment:
   Ok， I use a loop to convert byte[] to String instead of changing the checker.xml.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services