[jira] [Commented] (WICKET-4710) DataTable - Headers with OrderByBorder have invalid HTML markup

["Bertrand Guay-Paquet (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435188#comment-13435188 ] 

Bertrand Guay-Paquet commented on WICKET-4710:
----------------------------------------------

The problem I describe is problematic when making the OrderByBorder created link the one with the background image and padding to make the icons clickable.

Here is the css I use for the links:
a.wicket_orderNone,a.wicket_orderUp,a.wicket_orderDown {
	/* display: block;   <--- Must be added with WICKET-4690, but produces bad result of icons far from text */
	text-decoration: none;
	padding-right: 15px;
}

a.wicket_orderNone {
	background: url("images/orderNone.gif") no-repeat center right;
}

...
                
> DataTable - Headers with OrderByBorder have invalid HTML markup
> ---------------------------------------------------------------
>
>                 Key: WICKET-4710
>                 URL: https://issues.apache.org/jira/browse/WICKET-4710
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 6.0.0
>            Reporter: Bertrand Guay-Paquet
>              Labels: datatable
>         Attachments: screenshots.png
>
>
> WICKET-4690 changed the tag type to <div> for the content of DataTable cells. When a sortable column is used, this produces invalid HTML markup which can wreck css stylings.
> The markup is now:
> <th class="wicket_orderUp">
>   <a class="wicket_orderUp">
>     <div></div>
>   </a>
> </th>
> Note the <a> (inline element) containing a <div> (block element)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira