You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/06/11 02:21:48 UTC
Review Request 22447: Re-enabled "--acls" flag on master and updated example
tests to use authorization.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22447/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
Re-enabled "--acls" flag on master and updated example tests to use authorization.
Diffs
-----
src/master/flags.hpp ed08c6b9d317fb87ccefa1235f405c5238578188
src/tests/script.cpp e5885eedb84838b2e774f313679392b95a0a1169
src/tests/test_framework_test.sh a521b4713b2b63d2cf5d8422234d913063e3b485
Diff: https://reviews.apache.org/r/22447/diff/
Testing
-------
make check GTEST_FILTER="*Examples*"
Thanks,
Vinod Kone
Re: Review Request 22447: Re-enabled "--acls" flag on master and updated
example tests to use authorization.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22447/
-----------------------------------------------------------
(Updated June 11, 2014, 1:22 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
benm's.
also included "receive_offers" ACL in the flags help. NNFR.
Repository: mesos-git
Description
-------
Re-enabled "--acls" flag on master and updated example tests to use authorization.
Diffs (updated)
-----
src/master/flags.hpp ed08c6b9d317fb87ccefa1235f405c5238578188
src/tests/script.cpp e5885eedb84838b2e774f313679392b95a0a1169
src/tests/test_framework_test.sh a521b4713b2b63d2cf5d8422234d913063e3b485
Diff: https://reviews.apache.org/r/22447/diff/
Testing
-------
make check GTEST_FILTER="*Examples*"
Thanks,
Vinod Kone
Re: Review Request 22447: Re-enabled "--acls" flag on master and updated
example tests to use authorization.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22447/
-----------------------------------------------------------
(Updated June 11, 2014, 12:55 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
benm's. NNFR.
Repository: mesos-git
Description
-------
Re-enabled "--acls" flag on master and updated example tests to use authorization.
Diffs (updated)
-----
src/master/flags.hpp ed08c6b9d317fb87ccefa1235f405c5238578188
src/tests/script.cpp e5885eedb84838b2e774f313679392b95a0a1169
src/tests/test_framework_test.sh a521b4713b2b63d2cf5d8422234d913063e3b485
Diff: https://reviews.apache.org/r/22447/diff/
Testing
-------
make check GTEST_FILTER="*Examples*"
Thanks,
Vinod Kone
Re: Review Request 22447: Re-enabled "--acls" flag on master and updated
example tests to use authorization.
Posted by Vinod Kone <vi...@gmail.com>.
> On June 11, 2014, 12:27 a.m., Ben Mahler wrote:
> > src/master/flags.hpp, lines 211-212
> > <https://reviews.apache.org/r/22447/diff/1/?file=606896#file606896line211>
> >
> > Remove this?
done
> On June 11, 2014, 12:27 a.m., Ben Mahler wrote:
> > src/tests/script.cpp, line 137
> > <https://reviews.apache.org/r/22447/diff/1/?file=606897#file606897line137>
> >
> > No need for std::
done
> On June 11, 2014, 12:27 a.m., Ben Mahler wrote:
> > src/tests/script.cpp, lines 136-137
> > <https://reviews.apache.org/r/22447/diff/1/?file=606897#file606897line136>
> >
> > Move this above the write call?
I like the comment on top of the block pertaining to ACLs because it is all part of ACLs creation, similar to what we did with Credentials.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22447/#review45318
-----------------------------------------------------------
On June 11, 2014, 12:21 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22447/
> -----------------------------------------------------------
>
> (Updated June 11, 2014, 12:21 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Re-enabled "--acls" flag on master and updated example tests to use authorization.
>
>
> Diffs
> -----
>
> src/master/flags.hpp ed08c6b9d317fb87ccefa1235f405c5238578188
> src/tests/script.cpp e5885eedb84838b2e774f313679392b95a0a1169
> src/tests/test_framework_test.sh a521b4713b2b63d2cf5d8422234d913063e3b485
>
> Diff: https://reviews.apache.org/r/22447/diff/
>
>
> Testing
> -------
>
> make check GTEST_FILTER="*Examples*"
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 22447: Re-enabled "--acls" flag on master and updated
example tests to use authorization.
Posted by Ben Mahler <be...@gmail.com>.
> On June 11, 2014, 12:27 a.m., Ben Mahler wrote:
> > src/tests/script.cpp, lines 136-137
> > <https://reviews.apache.org/r/22447/diff/1/?file=606897#file606897line136>
> >
> > Move this above the write call?
>
> Vinod Kone wrote:
> I like the comment on top of the block pertaining to ACLs because it is all part of ACLs creation, similar to what we did with Credentials.
I was referring to the path variable (used only for the os::write call) rather than the comment.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22447/#review45318
-----------------------------------------------------------
On June 11, 2014, 12:55 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22447/
> -----------------------------------------------------------
>
> (Updated June 11, 2014, 12:55 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Re-enabled "--acls" flag on master and updated example tests to use authorization.
>
>
> Diffs
> -----
>
> src/master/flags.hpp ed08c6b9d317fb87ccefa1235f405c5238578188
> src/tests/script.cpp e5885eedb84838b2e774f313679392b95a0a1169
> src/tests/test_framework_test.sh a521b4713b2b63d2cf5d8422234d913063e3b485
>
> Diff: https://reviews.apache.org/r/22447/diff/
>
>
> Testing
> -------
>
> make check GTEST_FILTER="*Examples*"
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 22447: Re-enabled "--acls" flag on master and updated
example tests to use authorization.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22447/#review45318
-----------------------------------------------------------
Ship it!
src/master/flags.hpp
<https://reviews.apache.org/r/22447/#comment80128>
Remove this?
src/tests/script.cpp
<https://reviews.apache.org/r/22447/#comment80130>
Move this above the write call?
src/tests/script.cpp
<https://reviews.apache.org/r/22447/#comment80129>
No need for std::
- Ben Mahler
On June 11, 2014, 12:21 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22447/
> -----------------------------------------------------------
>
> (Updated June 11, 2014, 12:21 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Re-enabled "--acls" flag on master and updated example tests to use authorization.
>
>
> Diffs
> -----
>
> src/master/flags.hpp ed08c6b9d317fb87ccefa1235f405c5238578188
> src/tests/script.cpp e5885eedb84838b2e774f313679392b95a0a1169
> src/tests/test_framework_test.sh a521b4713b2b63d2cf5d8422234d913063e3b485
>
> Diff: https://reviews.apache.org/r/22447/diff/
>
>
> Testing
> -------
>
> make check GTEST_FILTER="*Examples*"
>
>
> Thanks,
>
> Vinod Kone
>
>