You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/05/31 18:53:15 UTC
Review Request 59689: Fix swagger sytax errors in Log Search REST API
doc
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59689/
-----------------------------------------------------------
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Bugs: AMBARI-21159
https://issues.apache.org/jira/browse/AMBARI-21159
Repository: ambari
Description
-------
Fix sytax errors regarding to generated swagger.yaml file:
- info did not contain version
- getClusterForServiceLog operationId is duplicated
Diffs
-----
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java 630e73a
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/AuditLogsResource.java 5312da8
Diff: https://reviews.apache.org/r/59689/diff/1/
Testing
-------
done. tried out with swagger online editor
Thanks,
Oliver Szabo
Re: Review Request 59689: Fix swagger sytax errors in Log Search REST
API doc
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59689/#review176516
-----------------------------------------------------------
Ship it!
Ship It!
- Miklos Gergely
On May 31, 2017, 6:53 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59689/
> -----------------------------------------------------------
>
> (Updated May 31, 2017, 6:53 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-21159
> https://issues.apache.org/jira/browse/AMBARI-21159
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix sytax errors regarding to generated swagger.yaml file:
> - info did not contain version
> - getClusterForServiceLog operationId is duplicated
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java 630e73a
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/AuditLogsResource.java 5312da8
>
>
> Diff: https://reviews.apache.org/r/59689/diff/1/
>
>
> Testing
> -------
>
> done. tried out with swagger online editor
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 59689: Fix swagger sytax errors in Log Search REST
API doc
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59689/#review176511
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On May 31, 2017, 6:53 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59689/
> -----------------------------------------------------------
>
> (Updated May 31, 2017, 6:53 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-21159
> https://issues.apache.org/jira/browse/AMBARI-21159
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix sytax errors regarding to generated swagger.yaml file:
> - info did not contain version
> - getClusterForServiceLog operationId is duplicated
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java 630e73a
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/AuditLogsResource.java 5312da8
>
>
> Diff: https://reviews.apache.org/r/59689/diff/1/
>
>
> Testing
> -------
>
> done. tried out with swagger online editor
>
>
> Thanks,
>
> Oliver Szabo
>
>