[GitHub] [pinot] KKcorps commented on a change in pull request #8333: Add support for Kinesis datasource in Github Events recipe

[GitBox <gi...@apache.org>]

KKcorps commented on a change in pull request #8333:
URL: https://github.com/apache/pinot/pull/8333#discussion_r823648112



##########
File path: pinot-plugins/pinot-stream-ingestion/pinot-kinesis/pom.xml
##########
@@ -39,6 +39,7 @@
     <aws.version>2.14.28</aws.version>
     <easymock.version>4.2</easymock.version>
     <reactive.version>1.0.2</reactive.version>
+    <localstack-utils.version>0.2.19</localstack-utils.version>

Review comment:
       I have. Test containers also uses Localstack only to mock Kinesis. And We are already use localstack for our KinesisIntegrationTests (in pinot-integration-tests module) so didn't want to introduce a new dependency.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org